avoid day long gaps in sample data #20897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Add Data
💚 Build Succeeded |
💚 Build Succeeded |
markov00
approved these changes
Jul 19, 2018
There was a problem hiding this comment.
Code LGTM.
I've tested the cases where tests fails using different timezone as specified #20020 (review) all tests passes.
cjcenizal
approved these changes
Jul 19, 2018
|
@cjcenizal Thanks for walking me through a much simpler way of translating the times. Unfortunately, the refactor was very large. Would you mind giving this another review? |
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
cjcenizal
approved these changes
Jul 20, 2018
| return new Date(year, month, date); | ||
| } | ||
|
|
||
| export function dateToISO8601IgnoringTime(date) { |
There was a problem hiding this comment.
Minor nit, but personally I think the only logical and consistent way to treat acronyms is to camel case them like any other word. So this would be dateToIso8601IgnoringTime which would case it consistently with iso8601ToDateIgnoringTime.
|
|
||
| // Translate source timestamp by targetReference timestamp, | ||
| // perserving the distance between source and sourceReference | ||
| export function translateTimeRelativeToDifference(source, sourceReference, targetReference) { |
There was a problem hiding this comment.
I renamed a variable here to help me reason about this code in the correct terms... it's a small change but maybe it will help others too?
export function translateTimeRelativeToDifference(source, sourceReference, targetReference) {
const sourceDate = iso8601ToDateIgnoringTime(source);
const sourceReferenceDate = iso8601ToDateIgnoringTime(sourceReference);
const targetReferenceDate = iso8601ToDateIgnoringTime(targetReference);
const timeDelta = sourceDate.getTime() - sourceReferenceDate.getTime();
const translatedDate = (new Date(targetReferenceDate.getTime() + timeDelta));
return `${dateToISO8601IgnoringTime(translatedDate)}T${source.substring(11)}`;
}|
|
||
| // Translate source timestamp by targetReference timestamp, | ||
| // perserving the week distance between source and sourceReference and day of week of the source timestamp | ||
| export function translateTimeRelativeToWeek(source, sourceReference, targetReference) { |
There was a problem hiding this comment.
I also added some comments here and changed some names to help me reason about this. Might be useful to others too.
export function translateTimeRelativeToWeek(source, sourceReference, targetReference) {
const sourceReferenceDate = iso8601ToDateIgnoringTime(sourceReference);
const targetReferenceDate = iso8601ToDateIgnoringTime(targetReference);
// If these dates were in the same week, how many days apart would they be?
const dayOfWeekDelta = sourceReferenceDate.getDay() - targetReferenceDate.getDay();
// If we pretend that the targetReference is actually the same day of the week as the
// sourceReference, then we can translate the source to the target while preserving their
// days of the week.
const normalizationDelta = dayOfWeekDelta * MILLISECONDS_IN_DAY;
const normalizedTargetReference =
dateToISO8601IgnoringTime(new Date(targetReferenceDate.getTime() + normalizationDelta));
return translateTimeRelativeToDifference(
source,
sourceReference,
normalizedTargetReference);
}
|
Ah nevermind I was looking at the wrong index pattern. Here's what I get using the sample data:
LGTM! |
💔 Build Failed |
💔 Build Failed |
|
Looks like flaky test jenkins, test this |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 22, 2018
* avoid day long gaps in sample data * avoid using toISOString to avoid an timezone problems * unskip sample test now that problem is fixed * use much better cj algorithm for translating time * cjcenizal review updates * update funtion name in install.js * push source reference date back a week
nreese
added a commit
that referenced
this pull request
Jul 23, 2018
* avoid day long gaps in sample data * avoid using toISOString to avoid an timezone problems * unskip sample test now that problem is fixed * use much better cj algorithm for translating time * cjcenizal review updates * update funtion name in install.js * push source reference date back a week
eokoneyo
added a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20807
There was a bug in the sample data timestamp adjustment logic that allowed for a days long gap in the data. The bug was that partial weeks were not accounted for resulting in bugs like: this Friday and last Friday both getting adjusted to this Friday.
This PR cleans up the timestamp adjustment logic to acount for partial weeks. The PR also ensures consistency with
Datemethods ensuring that only methods that return values in local time are used.Below is an example of what the data gap used to look like in Discover
