Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Jobs list bug fixes #20823

Merged
merged 1 commit into from
Jul 16, 2018
Merged

[ML] Jobs list bug fixes #20823

merged 1 commit into from
Jul 16, 2018

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 16, 2018 •
edited
Loading

Addresses a few issues in the new jobs list:

  • fixes bug where the refresh interval would be set multiple times causing the jobs list refresh to fire multiple times. ( @pheyos )
  • fixes issue where if you open and closed an expandable row before the job details have time to load, an error was thrown.
  • Fixes text overflow in delete confirmation modal
  • Only jobs which have datafeeds will be requested for the multi-job start action.
  • renames the directive file and embeds the template html as a string rather than being a separate file.

Not for release notes

@jgowdyelastic jgowdyelastic self-assigned this Jul 16, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 54cf83d into elastic:master Jul 16, 2018
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 16, 2018
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 16, 2018
@jgowdyelastic
[ML] Jobs list bug fixes (elastic#20823)
13e7adc
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jgowdyelastic added a commit that referenced this pull request Jul 16, 2018
@jgowdyelastic
[ML] Jobs list bug fixes (#20823) (#20829)
9157cf7
@jgowdyelastic
Copy link
Member Author

Related to #20150

@jgowdyelastic jgowdyelastic mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml review v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgowdyelastic @elasticmachine @walterra @peteharverson