[kbn-plugin-generator] Fix plugin naming inconsistency #20808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Jenkins, test this |
markov00
requested changes
Jul 16, 2018
💔 Build Failed |
jenkins test this |
💚 Build Succeeded |
|
jenkins test this |
markov00
approved these changes
Jul 17, 2018
markov00
added
Team:Core
💚 Build Succeeded |
markov00
changed the title
spalger
reviewed
Jul 17, 2018
| @@ -89,6 +89,7 @@ module.exports = function({ name }) { | |||
| kebabCase, | |||
There was a problem hiding this comment.
Is there any reason to leave kebabCase here? Can we get rid of it and the lodash.kebabcase module?
There was a problem hiding this comment.
You are right, I've also checked this and it's no more used. @aaronoah could you check again and in case remove that line?
markov00
added
the
bug
|
Jenkins test this |
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 17, 2018
<!-- Thank you for your interest in and contributing to Kibana! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md)? - If submitting code, have you included unit tests that cover the changes? - If submitting code, have you tested and built your code locally prior to submission with `yarn test && yarn build`? - If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. --> Make relevant generated files use snakeCase instead of kebabCase Closes elastic#20524
spalger
pushed a commit
that referenced
this pull request
Jul 18, 2018
|
6.4/6.x: 215c41c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make relevant generated files use snakeCase instead of kebabCase
Closes #20524