[kbn-es] Only enable security for trial #20803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
added
review
Team:Operations
💔 Build Failed |
💔 Build Failed |
|
retest |
jbudz
approved these changes
Jul 25, 2018
|
retest |
💔 Build Failed |
💔 Build Failed |
|
retest |
|
Fifth times a charm? |
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
tylersmalley
added a commit
that referenced
this pull request
Jul 26, 2018
Signed-off-by: Tyler Smalley <[email protected]>
|
6.5/6.x: 2ffae02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, you would be locked out of Kibana if you attempted to start a trial when using
kbn-es. This is due to the fact we were enabling security when running with a basic or trial license. We should only be enabling security for a trial license. The reason security is disabled for trial by default, is to allow for starting a trial at will since security requires additional configuration to set up authentication.To test:
yarn es snapshot@elastic/kibana-operations
Closes: #20799