Use EuiCodeBlock for JSON settings, and overflow if long value #20744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
commented
Jul 12, 2018
| <EuiCode> | ||
| default_value | ||
| </EuiCode> | ||
| <UNDEFINED> |
There was a problem hiding this comment.
UNDEFINED in place of React.Fragment is a bug which is fixed with jest >= v23.0.0. I'm investigating a possible jest upgrade in another branch.
💚 Build Succeeded |
bmcconaghy
approved these changes
Jul 13, 2018
| <Fragment> | ||
| Default: | ||
| <EuiCodeBlock | ||
| language="js" |
There was a problem hiding this comment.
should this be json instead of js?
There was a problem hiding this comment.
good call, for some reason I thought both would highlight the same, but json is a little cleaner. updated.
cjcenizal
approved these changes
Jul 13, 2018
💚 Build Succeeded |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Jul 13, 2018
jen-huang
added a commit
that referenced
this pull request
Jul 13, 2018
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20156
In Advanced Settings, change display of JSON default setting value to use
EuiCodeBlock, and use itsoverflowHeightprop for long values. Screenshot shows a long JSON default value and a short JSON value: