[Monitoring] Capitalize the license type #20683
Conversation
💚 Build Succeeded |
| @@ -54,12 +54,14 @@ export class LicenseViewController { | |||
| expiryDate = formatDateTimeLocal(license.expiry_date); | |||
| } | |||
|
|
|||
| const capitalizedType = license.type[0].toUpperCase() + license.type.slice(1); | |||
There was a problem hiding this comment.
This does fix the issue, but I think that this is the wrong place to fix it. We have two examples of this component being used and it's already been used differently between the two.
Instead of fixing it at the caller level, I think we should just do the case management of the license type inside of the component, which eliminates the need to think about it and simplifies caller code.
If you modify type there to have this behavior (you will also want to explicitly lowercase the type.slice(1) portion for parity; you should probably also use type.substr(1) like the other code), then this code change can go away and the code that you're effectively copying can also be removed:
You may also be interested in Lodash's startCase function.
This reverts commit 6a05bb1.
|
Anything for you @pickypg ❤️ |
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
* Capitalize the license type in monitoring * Revert "Capitalize the license type in monitoring" This reverts commit 38ad3a5. * Pass in the type capitalized * Revert "Pass in the type capitalized" This reverts commit 6a05bb1. * Capitalize type in license status directly so consumers do not need to worry about it
* Capitalize the license type in monitoring * Revert "Capitalize the license type in monitoring" This reverts commit 38ad3a5. * Pass in the type capitalized * Revert "Pass in the type capitalized" This reverts commit 6a05bb1. * Capitalize type in license status directly so consumers do not need to worry about it
|
Backport: 6.x: a5f2725 |
* Capitalize the license type in monitoring * Revert "Capitalize the license type in monitoring" This reverts commit 38ad3a5. * Pass in the type capitalized * Revert "Pass in the type capitalized" This reverts commit 6a05bb1. * Capitalize type in license status directly so consumers do not need to worry about it
Fixes #20276
This PR gives parity between the license UI in monitoring and the license UI in management by also capitalizing the license type