Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de-angularize indexPatterns Field and FieldList #20589

Merged
merged 5 commits into from
Jul 13, 2018
Merged

de-angularize indexPatterns Field and FieldList #20589

merged 5 commits into from
Jul 13, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 9, 2018 •
edited
Loading

This PR is the beginning of removing angular dependency from indexPatterns. It removes angular from Field and FieldList.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese requested review from cjcenizal and jen-huang July 9, 2018 22:39
@nreese nreese removed the WIP Work in progress label Jul 9, 2018
cjcenizal
cjcenizal approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I tested locally by using the field chooser in discover and creating a scripted field in management. Everything worked normally. Just had one question.

src/ui/public/index_patterns/__tests__/_index_pattern.test.js Outdated
};
})
}));
jest.mock('ui/chrome',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added? I tried running the tests without it and there didn't seem to be any difference.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Jul 10, 2018

unrelated test error in kibana visualization

fail: "visualize app input control visualization chained controls should clear child control dropdown when parent control value is removed"
17:36:56    │ proc  [ftr]        │        Error: expected false to equal true
17:36:56    │ proc  [ftr]        │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
17:36:56    │ proc  [ftr]        │         at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
17:36:56    │ proc  [ftr]        │         at Context.it (test/functional/apps/visualize/_input_control_vis.js:284:31)
17:36:56    │ proc  [ftr]        │         at <anonymous>
17:36:56    │ proc  [ftr]        │         at process._tickCallback (internal/process/next_tick.js:188:7)

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jen-huang
jen-huang approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally, tested creating index pattern, editing fields, and using them in visualizations.

LGTM

@nreese nreese merged commit 16e9a7e into elastic:master Jul 13, 2018
nreese added a commit to nreese/kibana that referenced this pull request Jul 13, 2018
@nreese
de-angularize indexPatterns Field and FieldList (elastic#20589)
f3661ec 
* de-angularize indexPatterns Field and FieldList

* do not remove shortDots angular filter

* remove ui/chrome mock in _index_pattern test
@nreese nreese mentioned this pull request Jul 13, 2018
Merged
nreese added a commit that referenced this pull request Jul 13, 2018
@nreese
de-angularize indexPatterns Field and FieldList (#20589) (#20787)
5fae20e 
* de-angularize indexPatterns Field and FieldList

* do not remove shortDots angular filter

* remove ui/chrome mock in _index_pattern test
yankouskia pushed a commit to yankouskia/kibana that referenced this pull request Jul 16, 2018
@nreese
de-angularize indexPatterns Field and FieldList (elastic#20589)
b5b2ee1 
* de-angularize indexPatterns Field and FieldList

* do not remove shortDots angular filter

* remove ui/chrome mock in _index_pattern test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
chore v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @cjcenizal @jen-huang @stacey-gammon