Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] unskip kb user instructions test in serverless #205519

Merged
merged 5 commits into from
Jan 4, 2025
Merged

[Obs AI Assistant] unskip kb user instructions test in serverless #205519

merged 5 commits into from
Jan 4, 2025
+117 −64

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Jan 3, 2025 •
edited by kibanamachine
Loading

Summary

Resolves #192886

  • Unskips knowledge_base_user_instructions.spec.ts in serverless
    • stays skipped in mki due to proxy usage issue
    • Duplicates new changes from stateful test
  • Removes skipInMKI tags for:
    knowledge_base_setup.spec.ts
    knowledge_base.spec.ts
    knowledge_base_status.spec.ts

If #192718 is merged before this, I will move knowledge_base_user_instructions.spec.ts to deployment agnostic. Otherwise It can be done in that PR or another.

@neptunian neptunian added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Obs AI Assistant Observability AI Assistant labels Jan 3, 2025
@neptunian neptunian requested a review from a team as a code owner January 3, 2025 16:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@neptunian neptunian mentioned this pull request Jan 3, 2025
Closed
5 tasks
@neptunian neptunian mentioned this pull request Jan 3, 2025
Open
@neptunian neptunian enabled auto-merge (squash) January 3, 2025 19:31
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / Serverless Common UI - Management Index Management Data Streams Modify data streams index mode allows to downgrade data stream from logsdb to standard index mode

Metrics [docs]

✅ unchanged

History

viduni94
viduni94 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@viduni94 viduni94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neptunian neptunian merged commit b17b10e into elastic:main Jan 4, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12613892733

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 4, 2025
@neptunian
[Obs AI Assistant] unskip kb user instructions test in serverless (el…
a370292 
…astic#205519)

## Summary
Resolves elastic#192886

- Unskips `knowledge_base_user_instructions.spec.ts` in serverless
  - stays skipped in mki due to proxy usage issue
  - Duplicates new changes from non serverless
- Removes `skipInMKI` tags for:
`knowledge_base_setup.spec.ts`
`knowledge_base.spec.ts `
`knowledge_base_status.spec.ts`

If elastic#192718 is merged before
this, I will move `knowledge_base_user_instructions.spec.ts` to
deployment agnostic. Otherwise It can be done in that PR or another.

(cherry picked from commit b17b10e)
@kibanamachine kibanamachine mentioned this pull request Jan 4, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 4, 2025
@kibanamachine @neptunian
[8.x] [Obs AI Assistant] unskip kb user instructions test in serverle…
3881274 
…ss (#205519) (#205564)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] unskip kb user instructions test in serverless
(#205519)](#205519)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sandra
G","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-04T21:32:32Z","message":"[Obs
AI Assistant] unskip kb user instructions test in serverless
(#205519)\n\n## Summary\r\nResolves
https://github.com/elastic/kibana/issues/192886\r\n\r\n- Unskips
`knowledge_base_user_instructions.spec.ts` in serverless\r\n - stays
skipped in mki due to proxy usage issue\r\n - Duplicates new changes
from non serverless\r\n- Removes `skipInMKI` tags
for:\r\n`knowledge_base_setup.spec.ts`\r\n`knowledge_base.spec.ts
`\r\n`knowledge_base_status.spec.ts`\r\n\r\n\r\nIf
#192718 is merged
before\r\nthis, I will move `knowledge_base_user_instructions.spec.ts`
to\r\ndeployment agnostic. Otherwise It can be done in that PR or
another.","sha":"b17b10eea1aa465a4291ce716dba473eb9195cb1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Obs
AI Assistant"],"title":"[Obs AI Assistant] unskip kb user instructions
test in
serverless","number":205519,"url":"https://github.com/elastic/kibana/pull/205519","mergeCommit":{"message":"[Obs
AI Assistant] unskip kb user instructions test in serverless
(#205519)\n\n## Summary\r\nResolves
https://github.com/elastic/kibana/issues/192886\r\n\r\n- Unskips
`knowledge_base_user_instructions.spec.ts` in serverless\r\n - stays
skipped in mki due to proxy usage issue\r\n - Duplicates new changes
from non serverless\r\n- Removes `skipInMKI` tags
for:\r\n`knowledge_base_setup.spec.ts`\r\n`knowledge_base.spec.ts
`\r\n`knowledge_base_status.spec.ts`\r\n\r\n\r\nIf
#192718 is merged
before\r\nthis, I will move `knowledge_base_user_instructions.spec.ts`
to\r\ndeployment agnostic. Otherwise It can be done in that PR or
another.","sha":"b17b10eea1aa465a4291ce716dba473eb9195cb1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205519","number":205519,"mergeCommit":{"message":"[Obs
AI Assistant] unskip kb user instructions test in serverless
(#205519)\n\n## Summary\r\nResolves
https://github.com/elastic/kibana/issues/192886\r\n\r\n- Unskips
`knowledge_base_user_instructions.spec.ts` in serverless\r\n - stays
skipped in mki due to proxy usage issue\r\n - Duplicates new changes
from non serverless\r\n- Removes `skipInMKI` tags
for:\r\n`knowledge_base_setup.spec.ts`\r\n`knowledge_base.spec.ts
`\r\n`knowledge_base_status.spec.ts`\r\n\r\n\r\nIf
#192718 is merged
before\r\nthis, I will move `knowledge_base_user_instructions.spec.ts`
to\r\ndeployment agnostic. Otherwise It can be done in that PR or
another.","sha":"b17b10eea1aa465a4291ce716dba473eb9195cb1"}}]}]
BACKPORT-->

Co-authored-by: Sandra G <[email protected]>
@pheyos pheyos mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viduni94 viduni94 viduni94 approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] fix knowledge base tests failing in serverless
4 participants
@neptunian @elasticmachine @kibanamachine @viduni94