Split i18n engine to specific parts by tech and by env #20513

yankouskia · 2018-07-06T11:05:35Z

Split i18n engine to specific parts by technology (core, React, Angular) and by environment (Browser and Node)

#20466

elasticmachine · 2018-07-06T13:26:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

azasypkin

I like the idea in general. I left a few questions and one concern regarding mixing of kbn/i18n reorg changes with intl polyfill, I'd rather split this into two separate PRs.

azasypkin · 2018-07-09T16:38:05Z

packages/kbn-i18n/angular/package.json

@@ -0,0 +1,4 @@
+{
+  "browser": "../target/web/angular",
+  "main": "../target/node/angular"


question: is there any reason why we need main (same question for react)?

Yes. React and Angular is built in order to be used in Node as well as in browsers (even it will be changed, believe that devs will add 2 different sections as well). And we use Node environment in tests, and potentially can use ssr where Node env as well. That's why I split it to 2 parts. Another point - it's babel build. It is just fortuity, that client-preset is working on server, so we should be consistent with it.

nice use of fortuity ;)

azasypkin · 2018-07-09T16:39:40Z

packages/kbn-i18n/package.json

  "module": "./src/index.js",
  "version": "1.0.0",
  "license": "Apache-2.0",
  "private": true,
  "scripts": {
    "build": "yarn build:web && yarn build:node",
-    "build:web": "cross-env BABEL_ENV=web babel src --out-dir target/web",
-    "build:node": "cross-env BABEL_ENV=node babel src --out-dir target/node",
+    "build:web": "cross-env BABEL_ENV=web babel src --out-dir target/web --copy-files",


question: why do we need --copy-files?

We need to copy package.json for correct resolving modules

azasypkin · 2018-07-09T16:41:13Z

packages/kbn-i18n/package.json

-    "build:web": "cross-env BABEL_ENV=web babel src --out-dir target/web",
-    "build:node": "cross-env BABEL_ENV=node babel src --out-dir target/node",
+    "build:web": "cross-env BABEL_ENV=web babel src --out-dir target/web --copy-files",
+    "build:node": "cross-env BABEL_ENV=node babel src --out-dir target/node --copy-files",


question: I still see target/node/angular|react, would it make sense to use babel src/core in build:node or something like that to avoid unnecessary files in target/node?

point in previous comment

azasypkin · 2018-07-09T17:12:50Z

packages/kbn-i18n/src/core/i18n/intl_polyfill.js

@@ -17,12 +17,6 @@
 * under the License.


issue: looks like intl polyfill is out of scope for this particular PR, can we add it in a separate PR and not mix two unrelated changes?

Yes, actually you are absolutely right, but I added because of 2 reasons:

It is really small change and easy to review, but if I would add it in another PR, it would be blocked.

In this PR I added support for different envs. And would like to deliver fully working code without Intl issues

It is really small change and easy to review

Hmm, can't agree here, it's a new dependency and we should know and discuss all the consequences it may have (e.g. build size). And it's for node-only, does it block anything specific right now in Index Management localization effort?

but if I would add it in another PR, it would be blocked.

That's totally fine, let's solve issues when they arrive.

@azasypkin you are right. moved this logic

azasypkin · 2018-07-09T17:14:38Z

packages/kbn-i18n/src/core/i18n/package.json

@@ -0,0 +1,4 @@
+{
+  "browser": "./index.js",


nit: I'd still keep default index.js for node and browser.js for browser similar to what is used by npm itself: main for node and browser for browser.

you are right, will fix it, thank you!

azasypkin · 2018-07-09T17:21:50Z

packages/kbn-i18n/src/core/i18n/index.js

@@ -0,0 +1,21 @@
+/*


question: btw, why we do we need core/i18n subfolder, can't we use just core?

I did it because of next reason: this functionality is used in Angular and React wrappers, and here we should also split into browser and node implementation as React for instance is the same for both. Also, I split real core from loader, where we do not have any environment specific code.

elasticmachine · 2018-07-10T07:40:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-10T11:16:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

azasypkin

LGTM, the only thing that I'd do differently is to move core/index.js and core/lodader.js into src/ root and put everything from core/i18n into core directly to reduce seemingly unnecessary nested i18n folder. But please tell me if I'm missing something.

elasticmachine · 2018-07-12T08:53:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-12T15:16:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-13T11:18:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-13T13:23:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

rhoboat

I like it.

* split to packages in accordance to specific library * split to packages depending on tech and environment * make env modules names consistent * remove intl polyfilling * move laoder to root, i18n folder to core

LeanidShutau · 2018-08-02T08:59:20Z

6.x/6.5: 7026148

yankouskia added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n labels Jul 6, 2018

elastic deleted a comment from elasticmachine Jul 6, 2018

yankouskia requested review from azasypkin, epixa and rhoboat July 6, 2018 14:14

jinmu03 requested a review from spalger July 8, 2018 04:42

maryia-lapata mentioned this pull request Jul 9, 2018

Localization "Index Patterns" tab #20525

Merged

azasypkin requested changes Jul 9, 2018

View reviewed changes

yankouskia mentioned this pull request Jul 10, 2018

Feature/node intl polyfill #20613

Closed

yankouskia requested a review from azasypkin July 11, 2018 08:46

azasypkin removed the request for review from epixa July 11, 2018 14:37

azasypkin approved these changes Jul 11, 2018

View reviewed changes

yankouskia requested review from rhoboat and removed request for rhoboat July 12, 2018 09:22

Aliaksandr Yankouski added 5 commits July 12, 2018 16:53

split to packages in accordance to specific library

fdfc4a1

split to packages depending on tech and environment

1789598

make env modules names consistent

147fd86

remove intl polyfilling

850548d

move laoder to root, i18n folder to core

4c236db

yankouskia force-pushed the feature/partial-i18n branch from 44132a9 to 4c236db Compare July 12, 2018 13:53

azasypkin mentioned this pull request Jul 12, 2018

Use injectI18n Higher-Order Component instead of I18nContext #20542

Merged

merge latest master

5284860

azasypkin mentioned this pull request Jul 13, 2018

I18n tests #20306

Merged

rhoboat approved these changes Jul 16, 2018

View reviewed changes

yankouskia merged commit adc4185 into elastic:master Jul 16, 2018

yankouskia deleted the feature/partial-i18n branch July 16, 2018 14:02

LeanidShutau mentioned this pull request Jul 18, 2018

Fix i18n default formats injection into en.json #20929

Merged

LeanidShutau added the backport pending label Aug 1, 2018

LeanidShutau mentioned this pull request Aug 1, 2018

[6.x] Split i18n engine to specific parts by tech and by env (#20513) #21543

Merged

LeanidShutau added backported v6.5.0 and removed backport pending labels Aug 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split i18n engine to specific parts by tech and by env #20513

Split i18n engine to specific parts by tech and by env #20513

yankouskia commented Jul 6, 2018 •

edited

Loading

elasticmachine commented Jul 6, 2018

azasypkin left a comment

azasypkin Jul 9, 2018

yankouskia Jul 10, 2018

rhoboat Jul 16, 2018

azasypkin Jul 9, 2018

yankouskia Jul 10, 2018

azasypkin Jul 9, 2018

yankouskia Jul 10, 2018

azasypkin Jul 9, 2018

yankouskia Jul 10, 2018

azasypkin Jul 10, 2018

yankouskia Jul 10, 2018

azasypkin Jul 9, 2018

yankouskia Jul 10, 2018

azasypkin Jul 9, 2018

yankouskia Jul 10, 2018

elasticmachine commented Jul 10, 2018

elasticmachine commented Jul 10, 2018

azasypkin left a comment

elasticmachine commented Jul 12, 2018

elasticmachine commented Jul 12, 2018

elasticmachine commented Jul 13, 2018

elasticmachine commented Jul 13, 2018

rhoboat left a comment

LeanidShutau commented Aug 2, 2018

Split i18n engine to specific parts by tech and by env #20513

Split i18n engine to specific parts by tech and by env #20513

Conversation

yankouskia commented Jul 6, 2018 • edited Loading

elasticmachine commented Jul 6, 2018

💚 Build Succeeded

azasypkin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jul 10, 2018

💔 Build Failed

elasticmachine commented Jul 10, 2018

💚 Build Succeeded

azasypkin left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 12, 2018

💚 Build Succeeded

elasticmachine commented Jul 12, 2018

💚 Build Succeeded

elasticmachine commented Jul 13, 2018

💔 Build Failed

elasticmachine commented Jul 13, 2018

💚 Build Succeeded

rhoboat left a comment

Choose a reason for hiding this comment

LeanidShutau commented Aug 2, 2018

yankouskia commented Jul 6, 2018 •

edited

Loading