Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove BETA warning from Ruby agent instructions #20482

Closed
wants to merge 1 commit into from
Closed

[APM] Remove BETA warning from Ruby agent instructions #20482

wants to merge 1 commit into from

Conversation

mikker
Copy link

@mikker mikker commented Jul 5, 2018

As far as I could see, this is the only mention of BETA which the agent isn't anymore 😄

@mikker mikker added the v6.4.0 label Jul 5, 2018
@mikker mikker self-assigned this Jul 5, 2018
@mikker mikker requested review from sorenlouv and makwarth July 5, 2018 11:01
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mikker
Copy link
Author

mikker commented Jul 5, 2018

CI failure doesn't look related.

@sorenlouv
Copy link
Member

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
Copy link
Member

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikker
Copy link
Author

mikker commented Oct 3, 2018

@sqren What do we do here? Was it already removed? Bump!

@sorenlouv
Copy link
Member

Oh man. Forgot to merge, and now there is a bunch of conflicts due to translations... Will look into this later today.

@makwarth
Copy link

makwarth commented Oct 3, 2018

Hm, hasn't this been merged / fixed? I don't see Beta mentions in master

@sorenlouv
Copy link
Member

Ah yes. This was done in #21477. Closing

@sorenlouv sorenlouv closed this Oct 3, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mikker mikker deleted the apm-ruby-instructions branch October 3, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants