Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TSVB test #20481

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Fix flaky TSVB test #20481

merged 1 commit into from
Jul 5, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jul 5, 2018

The test had a missing waitUntilLoadingHasFinished() why the upcoming test tended to fail, since it still saw the old render state (e.g. https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/5998/console).

@timroes timroes requested review from markov00 and ppisljar July 5, 2018 09:54
@timroes timroes added test v7.0.0 v6.4.0 Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jul 5, 2018
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 9e7ea33 into elastic:master Jul 5, 2018
@timroes timroes deleted the fix-flaky-tsvb-test branch July 5, 2018 11:17
timroes added a commit to timroes/kibana that referenced this pull request Jul 5, 2018
timroes added a commit that referenced this pull request Jul 5, 2018
@kertal kertal mentioned this pull request Jan 15, 2020
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants