[ML] Anomaly Detection: Datafeed counts job messages table responsiveness fix #204625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtj
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
| @@ -66,23 +66,24 @@ export const JobMessages: FC<JobMessagesProps> = ({ | |||
| '' | |||
| ), | |||
| render: (message: JobMessage) => <JobIcon message={message} />, | |||
| width: `${euiTheme.size.l}`, | |||
| width: `${euiTheme.size.xl}`, | |||
| align: 'center', | |||
There was a problem hiding this comment.
I think this will need some rework as these column widths don't work so well inside the expanded rows in the jobs lists:
There was a problem hiding this comment.
Fixed in: #be95add
I think all places are covered, but I might be wrong (AD jobs table, DFA jobs table, datafeed counts flyout)
peteharverson
approved these changes
Dec 19, 2024
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @rbrtj |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12465682847 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 23, 2024
…ness fix (elastic#204625) Fix for: [elastic#204589](elastic#204589) DFA jobs table: <img width="1003" alt="image" src="https://github.com/user-attachments/assets/72930708-eba6-4167-8aab-66dfd5a67691" /> AD jobs table: <img width="1225" alt="image" src="https://github.com/user-attachments/assets/9b66ac57-8a6c-43dd-8bdf-9eda5d7bf2ea" /> Datafeed counts job messages table: https://github.com/user-attachments/assets/62cb6708-bdc2-4f79-b016-b3c43486dd3b --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 29984c4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 23, 2024
…onsiveness fix (#204625) (#205080) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Anomaly Detection: Datafeed counts job messages table responsiveness fix (#204625)](#204625) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-23T10:57:31Z","message":"[ML] Anomaly Detection: Datafeed counts job messages table responsiveness fix (#204625)\n\nFix for: [#204589](https://github.com/elastic/kibana/issues/204589)\n\nDFA jobs table:\n<img width=\"1003\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/72930708-eba6-4167-8aab-66dfd5a67691\"\n/>\n\nAD jobs table:\n<img width=\"1225\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9b66ac57-8a6c-43dd-8bdf-9eda5d7bf2ea\"\n/>\n\nDatafeed counts job messages table:\n\n\nhttps://github.com/user-attachments/assets/62cb6708-bdc2-4f79-b016-b3c43486dd3b\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"29984c48bdca25336fc5da69484380dc3232b73d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly Detection","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML] Anomaly Detection: Datafeed counts job messages table responsiveness fix","number":204625,"url":"https://github.com/elastic/kibana/pull/204625","mergeCommit":{"message":"[ML] Anomaly Detection: Datafeed counts job messages table responsiveness fix (#204625)\n\nFix for: [#204589](https://github.com/elastic/kibana/issues/204589)\n\nDFA jobs table:\n<img width=\"1003\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/72930708-eba6-4167-8aab-66dfd5a67691\"\n/>\n\nAD jobs table:\n<img width=\"1225\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9b66ac57-8a6c-43dd-8bdf-9eda5d7bf2ea\"\n/>\n\nDatafeed counts job messages table:\n\n\nhttps://github.com/user-attachments/assets/62cb6708-bdc2-4f79-b016-b3c43486dd3b\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"29984c48bdca25336fc5da69484380dc3232b73d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204625","number":204625,"mergeCommit":{"message":"[ML] Anomaly Detection: Datafeed counts job messages table responsiveness fix (#204625)\n\nFix for: [#204589](https://github.com/elastic/kibana/issues/204589)\n\nDFA jobs table:\n<img width=\"1003\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/72930708-eba6-4167-8aab-66dfd5a67691\"\n/>\n\nAD jobs table:\n<img width=\"1225\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9b66ac57-8a6c-43dd-8bdf-9eda5d7bf2ea\"\n/>\n\nDatafeed counts job messages table:\n\n\nhttps://github.com/user-attachments/assets/62cb6708-bdc2-4f79-b016-b3c43486dd3b\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"29984c48bdca25336fc5da69484380dc3232b73d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #204589
DFA jobs table:
AD jobs table:
Datafeed counts job messages table:
Screen.Recording.2024-12-19.at.15.44.50.mov