[eem] disable entity discovery on plugin startup #204536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
release_note:skip
This reverts commit b850ef6.
|
Pinging @elastic/obs-entities (Team:obs-entities) |
miltonhultgren
approved these changes
Dec 18, 2024
💚 Build Succeeded
Metrics [docs]History
cc @klacabane |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12413761779 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
Disable entity discovery on plugin startup and remove some related files. We'll need a follow up to cleanup endpoints. ### Testing - enable entity discovery from `main` with `PUT kbn:/internal/entities/managed/enablement`, preferably in a cluster with data so you can verify that the `.entities*` indices are also deleted - checkout that branch and start kibana - verify all v1 builtin definitions with their transforms/templates/pipelines are deleted. `.entities` indices for these definitions should also be gone --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
klacabane
added a commit
to klacabane/kibana
that referenced
this pull request
Dec 20, 2024
Disable entity discovery on plugin startup and remove some related files. We'll need a follow up to cleanup endpoints. ### Testing - enable entity discovery from `main` with `PUT kbn:/internal/entities/managed/enablement`, preferably in a cluster with data so you can verify that the `.entities*` indices are also deleted - checkout that branch and start kibana - verify all v1 builtin definitions with their transforms/templates/pipelines are deleted. `.entities` indices for these definitions should also be gone --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 505cc0f) # Conflicts: # x-pack/platform/plugins/shared/entity_manager/server/lib/entities/built_in/services_from_ecs_data.ts
klacabane
added a commit
that referenced
this pull request
Dec 23, 2024
…5059) # Backport This will backport the following commits from `main` to `8.x`: - [[eem] disable entity discovery on plugin startup (#204536)](#204536) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Lacabane","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T13:35:12Z","message":"[eem] disable entity discovery on plugin startup (#204536)\n\nDisable entity discovery on plugin startup and remove some related\nfiles.\n\nWe'll need a follow up to cleanup endpoints.\n\n### Testing\n\n- enable entity discovery from `main` with `PUT\nkbn:/internal/entities/managed/enablement`, preferably in a cluster with\ndata so you can verify that the `.entities*` indices are also deleted\n- checkout that branch and start kibana\n- verify all v1 builtin definitions with their\ntransforms/templates/pipelines are deleted. `.entities` indices for\nthese definitions should also be gone\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"505cc0fbbb901263b3a07d2b1a2f7b310a690e18","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","backport:prev-minor","Team:obs-entities"],"number":204536,"url":"https://github.com/elastic/kibana/pull/204536","mergeCommit":{"message":"[eem] disable entity discovery on plugin startup (#204536)\n\nDisable entity discovery on plugin startup and remove some related\nfiles.\n\nWe'll need a follow up to cleanup endpoints.\n\n### Testing\n\n- enable entity discovery from `main` with `PUT\nkbn:/internal/entities/managed/enablement`, preferably in a cluster with\ndata so you can verify that the `.entities*` indices are also deleted\n- checkout that branch and start kibana\n- verify all v1 builtin definitions with their\ntransforms/templates/pipelines are deleted. `.entities` indices for\nthese definitions should also be gone\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"505cc0fbbb901263b3a07d2b1a2f7b310a690e18"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204536","number":204536,"mergeCommit":{"message":"[eem] disable entity discovery on plugin startup (#204536)\n\nDisable entity discovery on plugin startup and remove some related\nfiles.\n\nWe'll need a follow up to cleanup endpoints.\n\n### Testing\n\n- enable entity discovery from `main` with `PUT\nkbn:/internal/entities/managed/enablement`, preferably in a cluster with\ndata so you can verify that the `.entities*` indices are also deleted\n- checkout that branch and start kibana\n- verify all v1 builtin definitions with their\ntransforms/templates/pipelines are deleted. `.entities` indices for\nthese definitions should also be gone\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"505cc0fbbb901263b3a07d2b1a2f7b310a690e18"}}]}] BACKPORT-->
kibanamachine
added
v8.18.0
and removed
backport missing
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
Disable entity discovery on plugin startup and remove some related files. We'll need a follow up to cleanup endpoints. ### Testing - enable entity discovery from `main` with `PUT kbn:/internal/entities/managed/enablement`, preferably in a cluster with data so you can verify that the `.entities*` indices are also deleted - checkout that branch and start kibana - verify all v1 builtin definitions with their transforms/templates/pipelines are deleted. `.entities` indices for these definitions should also be gone --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
Disable entity discovery on plugin startup and remove some related files. We'll need a follow up to cleanup endpoints. ### Testing - enable entity discovery from `main` with `PUT kbn:/internal/entities/managed/enablement`, preferably in a cluster with data so you can verify that the `.entities*` indices are also deleted - checkout that branch and start kibana - verify all v1 builtin definitions with their transforms/templates/pipelines are deleted. `.entities` indices for these definitions should also be gone --------- Co-authored-by: kibanamachine <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Disable entity discovery on plugin startup and remove some related files. We'll need a follow up to cleanup endpoints. ### Testing - enable entity discovery from `main` with `PUT kbn:/internal/entities/managed/enablement`, preferably in a cluster with data so you can verify that the `.entities*` indices are also deleted - checkout that branch and start kibana - verify all v1 builtin definitions with their transforms/templates/pipelines are deleted. `.entities` indices for these definitions should also be gone --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable entity discovery on plugin startup and remove some related files.
We'll need a follow up to cleanup endpoints.
Testing
mainwithPUT kbn:/internal/entities/managed/enablement, preferably in a cluster with data so you can verify that the.entities*indices are also deleted.entitiesindices for these definitions should also be gone