[Entity Analytics] Fix flickering "Enable risk engine" button #204486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
bug
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
jaredburgettelastic
approved these changes
Dec 16, 2024
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @hop-dev |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12371007945 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
…c#204486) ## Summary When we refetch the engine status, the enable component was flickering, I have changed it so we only load on the first request, after that we keep displaying the "stale" value while the request is fetching. Here is the flicker, blink and you'll miss it! https://github.com/user-attachments/assets/5271674c-1534-470a-996f-058afd5ed76f (cherry picked from commit c4cf9fe)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2024
…; button (#204486) (#204534) # Backport This will backport the following commits from `main` to `8.x`: - [[Entity Analytics] Fix flickering "Enable risk engine" button (#204486)](#204486) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T10:22:29Z","message":"[Entity Analytics] Fix flickering \"Enable risk engine\" button (#204486)\n\n## Summary\n\nWhen we refetch the engine status, the enable component was flickering,\nI have changed it so we only load on the first request, after that we\nkeep displaying the \"stale\" value while the request is fetching.\n\nHere is the flicker, blink and you'll miss it!\n\n\n\nhttps://github.com/user-attachments/assets/5271674c-1534-470a-996f-058afd5ed76f","sha":"c4cf9fe8a53174fd61eedf4a7cd3e1b3988decab","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Entity Analytics","backport:version","v8.18.0"],"title":"[Entity Analytics] Fix flickering \"Enable risk engine\" button","number":204486,"url":"https://github.com/elastic/kibana/pull/204486","mergeCommit":{"message":"[Entity Analytics] Fix flickering \"Enable risk engine\" button (#204486)\n\n## Summary\n\nWhen we refetch the engine status, the enable component was flickering,\nI have changed it so we only load on the first request, after that we\nkeep displaying the \"stale\" value while the request is fetching.\n\nHere is the flicker, blink and you'll miss it!\n\n\n\nhttps://github.com/user-attachments/assets/5271674c-1534-470a-996f-058afd5ed76f","sha":"c4cf9fe8a53174fd61eedf4a7cd3e1b3988decab"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204486","number":204486,"mergeCommit":{"message":"[Entity Analytics] Fix flickering \"Enable risk engine\" button (#204486)\n\n## Summary\n\nWhen we refetch the engine status, the enable component was flickering,\nI have changed it so we only load on the first request, after that we\nkeep displaying the \"stale\" value while the request is fetching.\n\nHere is the flicker, blink and you'll miss it!\n\n\n\nhttps://github.com/user-attachments/assets/5271674c-1534-470a-996f-058afd5ed76f","sha":"c4cf9fe8a53174fd61eedf4a7cd3e1b3988decab"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…c#204486) ## Summary When we refetch the engine status, the enable component was flickering, I have changed it so we only load on the first request, after that we keep displaying the "stale" value while the request is fetching. Here is the flicker, blink and you'll miss it! https://github.com/user-attachments/assets/5271674c-1534-470a-996f-058afd5ed76f
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…c#204486) ## Summary When we refetch the engine status, the enable component was flickering, I have changed it so we only load on the first request, after that we keep displaying the "stale" value while the request is fetching. Here is the flicker, blink and you'll miss it! https://github.com/user-attachments/assets/5271674c-1534-470a-996f-058afd5ed76f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we refetch the engine status, the enable component was flickering, I have changed it so we only load on the first request, after that we keep displaying the "stale" value while the request is fetching.
Here is the flicker, blink and you'll miss it!
Screen.Recording.2024-12-16.at.20.38.21.mov