Fix delete disabled state #204154
Merged
Fix delete disabled state #204154
+36
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
TinaHeiligers
commented
Dec 13, 2024
| @@ -417,7 +420,9 @@ export class Table extends PureComponent<TableProps, TableState> { | |||
| iconType="trash" | |||
| color="danger" | |||
| onClick={onDelete} | |||
| isDisabled={allHidden || !capabilities.savedObjectsManagement.delete} | |||
| isDisabled={ | |||
There was a problem hiding this comment.
Enables delete if some saved objects aren't hidden and delete is allowed
TinaHeiligers
commented
Dec 13, 2024
| ); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.getByTestId('savedObjectsManagementDelete')).toBeDisabled(); |
There was a problem hiding this comment.
Assert the button's disabled rather than relying on a snapshot, changes to which are easily overlooked (or "fixed" without inspection)
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12320393939 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2024
fix elastic#204095 Disables delete when no saved objects are selected or all objects selected are hidden and delete is allowed.  ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 4ee5222)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix delete disabled state (#204154)](#204154) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T17:39:48Z","message":"Fix delete disabled state (#204154)\n\nfix https://github.com/elastic/kibana/issues/204095\r\n\r\nDisables delete when no saved objects are selected or all objects\r\nselected are hidden and delete is allowed.\r\n\r\n\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves visual changes include a screenshot or\r\ngif.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ee52227bce2a1ffffaf930d41513bb0c644c199","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fix delete disabled state","number":204154,"url":"https://github.com/elastic/kibana/pull/204154","mergeCommit":{"message":"Fix delete disabled state (#204154)\n\nfix https://github.com/elastic/kibana/issues/204095\r\n\r\nDisables delete when no saved objects are selected or all objects\r\nselected are hidden and delete is allowed.\r\n\r\n\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves visual changes include a screenshot or\r\ngif.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ee52227bce2a1ffffaf930d41513bb0c644c199"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204154","number":204154,"mergeCommit":{"message":"Fix delete disabled state (#204154)\n\nfix https://github.com/elastic/kibana/issues/204095\r\n\r\nDisables delete when no saved objects are selected or all objects\r\nselected are hidden and delete is allowed.\r\n\r\n\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves visual changes include a screenshot or\r\ngif.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4ee52227bce2a1ffffaf930d41513bb0c644c199"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #204095
Disables delete when no saved objects are selected or all objects selected are hidden and delete is allowed.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.