Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[One Discover] Revert token change from vis palette #204054

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Dec 12, 2024

📓 Summary

Related to #202985

This change reverts a suggestion that was applied but that should only be valid for v9.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:OneDiscover Enrich Discover with contextual awareness labels Dec 12, 2024
@tonyghiani tonyghiani requested a review from a team as a code owner December 12, 2024 15:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing it!

@tonyghiani tonyghiani merged commit 08da946 into elastic:main Dec 12, 2024
17 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #66 / Entity Manager _search API includes source and additional metadata fields
  • [job] [logs] FTR Configs #99 / InfraOps App Metrics UI Home page with metrics present Saved Views should update the current saved view and load it

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 785.9KB 785.9KB -18.0B
unifiedDocViewer 115.9KB 115.9KB -18.0B
total -36.0B

@tonyghiani tonyghiani deleted the revert-color-change branch December 12, 2024 17:02
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12301184853

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204054

Questions ?

Please refer to the Backport tool documentation

@tonyghiani
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

tonyghiani added a commit to tonyghiani/kibana that referenced this pull request Dec 12, 2024
## 📓 Summary

Related to elastic#202985

This change reverts a suggestion that was applied but that should only
be valid for v9.

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
(cherry picked from commit 08da946)

# Conflicts:
#	packages/kbn-discover-utils/src/data_types/logs/utils/get_log_level_color.test.ts
#	packages/kbn-discover-utils/src/data_types/logs/utils/get_log_level_color.ts
tonyghiani added a commit that referenced this pull request Dec 12, 2024
…204092)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[One Discover] Revert token change from vis palette
(#204054)](#204054)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-12-12T17:01:49Z","message":"[One
Discover] Revert token change from vis palette (#204054)\n\n## 📓
Summary\r\n\r\nRelated to
https://github.com/elastic/kibana/pull/202985\r\n\r\nThis change reverts
a suggestion that was applied but that should only\r\nbe valid for
v9.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"08da9468b28afdad386b91a26507cd45e1c85098","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Project:OneDiscover"],"number":204054,"url":"https://github.com/elastic/kibana/pull/204054","mergeCommit":{"message":"[One
Discover] Revert token change from vis palette (#204054)\n\n## 📓
Summary\r\n\r\nRelated to
https://github.com/elastic/kibana/pull/202985\r\n\r\nThis change reverts
a suggestion that was applied but that should only\r\nbe valid for
v9.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"08da9468b28afdad386b91a26507cd45e1c85098"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204054","number":204054,"mergeCommit":{"message":"[One
Discover] Revert token change from vis palette (#204054)\n\n## 📓
Summary\r\n\r\nRelated to
https://github.com/elastic/kibana/pull/202985\r\n\r\nThis change reverts
a suggestion that was applied but that should only\r\nbe valid for
v9.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"08da9468b28afdad386b91a26507cd45e1c85098"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:OneDiscover Enrich Discover with contextual awareness release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants