[ResponseOps][Actions] Manual migration of action routes without access tags #204030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
approved these changes
Dec 13, 2024
cnasikas
approved these changes
Dec 13, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @adcoelho |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12316971187 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2024
…ss tags (elastic#204030) Connected with elastic/kibana-team#1322 ## Summary Since most action routes do not use access tags they need to be migrated to include a reason in the security params. [Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes) The following routes were migrated: - `createConnectorRoute` - `deleteConnectorRoute` - `getConnectorRoute` - `getAllConnectorsRoute` - `updateConnectorRoute` - `listTypesRoute` - `executeConnectorRoute` - `getGlobalExecutionLogRoute` - `getGlobalExecutionKPIRoute` - `getAllConnectorsIncludingSystemRoute` - `listTypesWithSystemRoute` - `getOAuthAccessToken` (cherry picked from commit 2dc790b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2024
…t access tags (#204030) (#204215) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Actions] Manual migration of action routes without access tags (#204030)](#204030) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T13:57:13Z","message":"[ResponseOps][Actions] Manual migration of action routes without access tags (#204030)\n\nConnected with https://github.com/elastic/kibana-team/issues/1322\r\n\r\n## Summary\r\n\r\nSince most action routes do not use access tags they need to be migrated\r\nto include a reason in the security params.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\nThe following routes were migrated:\r\n- `createConnectorRoute`\r\n- `deleteConnectorRoute`\r\n- `getConnectorRoute`\r\n- `getAllConnectorsRoute`\r\n- `updateConnectorRoute`\r\n- `listTypesRoute`\r\n- `executeConnectorRoute`\r\n- `getGlobalExecutionLogRoute`\r\n- `getGlobalExecutionKPIRoute`\r\n- `getAllConnectorsIncludingSystemRoute`\r\n- `listTypesWithSystemRoute`\r\n- `getOAuthAccessToken`","sha":"2dc790bbc024fd805aaafc9b2f6a5cc79dd2c6e2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RuleActions","backport:prev-minor","v8.18.0"],"title":"[ResponseOps][Actions] Manual migration of action routes without access tags ","number":204030,"url":"https://github.com/elastic/kibana/pull/204030","mergeCommit":{"message":"[ResponseOps][Actions] Manual migration of action routes without access tags (#204030)\n\nConnected with https://github.com/elastic/kibana-team/issues/1322\r\n\r\n## Summary\r\n\r\nSince most action routes do not use access tags they need to be migrated\r\nto include a reason in the security params.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\nThe following routes were migrated:\r\n- `createConnectorRoute`\r\n- `deleteConnectorRoute`\r\n- `getConnectorRoute`\r\n- `getAllConnectorsRoute`\r\n- `updateConnectorRoute`\r\n- `listTypesRoute`\r\n- `executeConnectorRoute`\r\n- `getGlobalExecutionLogRoute`\r\n- `getGlobalExecutionKPIRoute`\r\n- `getAllConnectorsIncludingSystemRoute`\r\n- `listTypesWithSystemRoute`\r\n- `getOAuthAccessToken`","sha":"2dc790bbc024fd805aaafc9b2f6a5cc79dd2c6e2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204030","number":204030,"mergeCommit":{"message":"[ResponseOps][Actions] Manual migration of action routes without access tags (#204030)\n\nConnected with https://github.com/elastic/kibana-team/issues/1322\r\n\r\n## Summary\r\n\r\nSince most action routes do not use access tags they need to be migrated\r\nto include a reason in the security params.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\nThe following routes were migrated:\r\n- `createConnectorRoute`\r\n- `deleteConnectorRoute`\r\n- `getConnectorRoute`\r\n- `getAllConnectorsRoute`\r\n- `updateConnectorRoute`\r\n- `listTypesRoute`\r\n- `executeConnectorRoute`\r\n- `getGlobalExecutionLogRoute`\r\n- `getGlobalExecutionKPIRoute`\r\n- `getAllConnectorsIncludingSystemRoute`\r\n- `listTypesWithSystemRoute`\r\n- `getOAuthAccessToken`","sha":"2dc790bbc024fd805aaafc9b2f6a5cc79dd2c6e2"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Antonio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected with https://github.com/elastic/kibana-team/issues/1322
Summary
Since most action routes do not use access tags they need to be migrated to include a reason in the security params.
Documentation.
The following routes were migrated:
createConnectorRoutedeleteConnectorRoutegetConnectorRoutegetAllConnectorsRouteupdateConnectorRoutelistTypesRouteexecuteConnectorRoutegetGlobalExecutionLogRoutegetGlobalExecutionKPIRoutegetAllConnectorsIncludingSystemRoutelistTypesWithSystemRoutegetOAuthAccessToken