Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Migrate alerting APIs without access tags. #204003

Merged
merged 3 commits into from
Dec 13, 2024
Merged

[ResponseOps][Rules] Migrate alerting APIs without access tags. #204003

merged 3 commits into from
Dec 13, 2024

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Dec 12, 2024 •
edited by kibanamachine
Loading

Connected with https://github.com/elastic/kibana-team/issues/1322

Summary

Since most rule routes do not use access tags they need to be migrated to include a reason in the security params.

Documentation.

Some routes use access tags and have already been migrated. These are:

-getFlappingSettingsRoute
-updateFlappingSettingsRoute
-createMaintenanceWindowRoute
-getMaintenanceWindowRoute
-updateMaintenanceWindowRoute
-deleteMaintenanceWindowRoute
-findMaintenanceWindowsRoute
-archiveMaintenanceWindowRoute
-finishMaintenanceWindowRoute
-getActiveMaintenanceWindowsRoute
-bulkGetMaintenanceWindowRoute
-getQueryDelaySettingsRoute
-updateQueryDelaySettingsRoute

All other were assigned the default reason for opting out.

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team v9.0.0 Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 12, 2024
@adcoelho adcoelho self-assigned this Dec 12, 2024
@adcoelho adcoelho requested a review from a team as a code owner December 12, 2024 11:21
@adcoelho adcoelho mentioned this pull request Dec 12, 2024
Merged
1 task
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @adcoelho

@adcoelho adcoelho merged commit 42704af into elastic:main Dec 13, 2024
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12314290257

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2024
@adcoelho
[ResponseOps][Rules] Migrate alerting APIs without access tags. (elas…
4a737e9 
…tic#204003)

Connected with elastic/kibana-team#1322

## Summary

Since most rule routes do not use access tags they need to be migrated
to include a reason in the security params.

[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)

Some routes **use** access tags and have already been migrated. These
are:

-`getFlappingSettingsRoute`
-`updateFlappingSettingsRoute`
-`createMaintenanceWindowRoute`
-`getMaintenanceWindowRoute`
-`updateMaintenanceWindowRoute`
-`deleteMaintenanceWindowRoute`
-`findMaintenanceWindowsRoute`
-`archiveMaintenanceWindowRoute`
-`finishMaintenanceWindowRoute`
-`getActiveMaintenanceWindowsRoute`
-`bulkGetMaintenanceWindowRoute`
-`getQueryDelaySettingsRoute`
-`updateQueryDelaySettingsRoute`

All other were assigned the default reason for opting out.

(cherry picked from commit 42704af)
@kibanamachine kibanamachine mentioned this pull request Dec 13, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 13, 2024
@kibanamachine @adcoelho
[8.x] [ResponseOps][Rules] Migrate alerting APIs without access tags. (…
0097c42 
…#204003) (#204190)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Migrate alerting APIs without access tags.
(#204003)](#204003)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T10:51:27Z","message":"[ResponseOps][Rules]
Migrate alerting APIs without access tags. (#204003)\n\nConnected with
https://github.com/elastic/kibana-team/issues/1322\r\n\r\n##
Summary\r\n\r\nSince most rule routes do not use access tags they need
to be migrated\r\nto include a reason in the security
params.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\nSome
routes **use** access tags and have already been migrated.
These\r\nare:\r\n\r\n-`getFlappingSettingsRoute`\r\n-`updateFlappingSettingsRoute`\r\n-`createMaintenanceWindowRoute`\r\n-`getMaintenanceWindowRoute`\r\n-`updateMaintenanceWindowRoute`\r\n-`deleteMaintenanceWindowRoute`\r\n-`findMaintenanceWindowsRoute`\r\n-`archiveMaintenanceWindowRoute`\r\n-`finishMaintenanceWindowRoute`\r\n-`getActiveMaintenanceWindowsRoute`\r\n-`bulkGetMaintenanceWindowRoute`\r\n-`getQueryDelaySettingsRoute`\r\n-`updateQueryDelaySettingsRoute`\r\n\r\nAll
other were assigned the default reason for opting
out.","sha":"42704af65d32abe3824643dcf4cc37221cfe11fb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Endpoint
Response","v9.0.0","Feature:Alerting/RulesFramework","backport:prev-minor","v8.18.0"],"title":"[ResponseOps][Rules]
Migrate alerting APIs without access
tags.","number":204003,"url":"https://github.com/elastic/kibana/pull/204003","mergeCommit":{"message":"[ResponseOps][Rules]
Migrate alerting APIs without access tags. (#204003)\n\nConnected with
https://github.com/elastic/kibana-team/issues/1322\r\n\r\n##
Summary\r\n\r\nSince most rule routes do not use access tags they need
to be migrated\r\nto include a reason in the security
params.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\nSome
routes **use** access tags and have already been migrated.
These\r\nare:\r\n\r\n-`getFlappingSettingsRoute`\r\n-`updateFlappingSettingsRoute`\r\n-`createMaintenanceWindowRoute`\r\n-`getMaintenanceWindowRoute`\r\n-`updateMaintenanceWindowRoute`\r\n-`deleteMaintenanceWindowRoute`\r\n-`findMaintenanceWindowsRoute`\r\n-`archiveMaintenanceWindowRoute`\r\n-`finishMaintenanceWindowRoute`\r\n-`getActiveMaintenanceWindowsRoute`\r\n-`bulkGetMaintenanceWindowRoute`\r\n-`getQueryDelaySettingsRoute`\r\n-`updateQueryDelaySettingsRoute`\r\n\r\nAll
other were assigned the default reason for opting
out.","sha":"42704af65d32abe3824643dcf4cc37221cfe11fb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204003","number":204003,"mergeCommit":{"message":"[ResponseOps][Rules]
Migrate alerting APIs without access tags. (#204003)\n\nConnected with
https://github.com/elastic/kibana-team/issues/1322\r\n\r\n##
Summary\r\n\r\nSince most rule routes do not use access tags they need
to be migrated\r\nto include a reason in the security
params.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\nSome
routes **use** access tags and have already been migrated.
These\r\nare:\r\n\r\n-`getFlappingSettingsRoute`\r\n-`updateFlappingSettingsRoute`\r\n-`createMaintenanceWindowRoute`\r\n-`getMaintenanceWindowRoute`\r\n-`updateMaintenanceWindowRoute`\r\n-`deleteMaintenanceWindowRoute`\r\n-`findMaintenanceWindowsRoute`\r\n-`archiveMaintenanceWindowRoute`\r\n-`finishMaintenanceWindowRoute`\r\n-`getActiveMaintenanceWindowsRoute`\r\n-`bulkGetMaintenanceWindowRoute`\r\n-`getQueryDelaySettingsRoute`\r\n-`updateQueryDelaySettingsRoute`\r\n\r\nAll
other were assigned the default reason for opting
out.","sha":"42704af65d32abe3824643dcf4cc37221cfe11fb"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Antonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

@georgianaonoleata1904 georgianaonoleata1904 Awaiting requested review from georgianaonoleata1904

Assignees

@adcoelho adcoelho

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adcoelho @elasticmachine @kibanamachine @cnasikas