Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Fix param parsing in qualified name identifier pattern nodes #203801

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[ES|QL] Fix param parsing in qualified name identifier pattern nodes #203801

merged 1 commit into from
Dec 11, 2024

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Dec 11, 2024 •
edited by kibanamachine
Loading

Summary

  • Handle params in "identifier pattern" parser nodes.

Checklist

@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.18.0 labels Dec 11, 2024
@vadimkibana vadimkibana requested a review from a team as a code owner December 11, 2024 13:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula
stratoula approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in my branch and works as expected 🙌

@vadimkibana vadimkibana enabled auto-merge (squash) December 11, 2024 13:47
@vadimkibana vadimkibana changed the title [ES|QL] Fix param parsing in qualified name [ES|QL] Fix param parsing in qualified name identifier pattern nodes Dec 11, 2024
@vadimkibana vadimkibana merged commit df16472 into elastic:main Dec 11, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12279362663

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #100 / APM API tests fleet/input_only_package.spec.ts basic no archive APM package policy input only package when ingesting events using the scoped api key the events can be seen on the Service Inventory Page

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.5MB 3.5MB +74.0B

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2024
@vadimkibana
[ES|QL] Fix param parsing in qualified name (elastic#203801)
4b288bf 
## Summary

- Handle params in "identifier pattern" parser nodes.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit df16472)
@kibanamachine kibanamachine mentioned this pull request Dec 11, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2024
@kibanamachine @vadimkibana
[8.x] [ES|QL] Fix param parsing in qualified name (#203801) (#203822)
4eb0b23 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Fix param parsing in qualified name
(#203801)](#203801)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T15:17:16Z","message":"[ES|QL]
Fix param parsing in qualified name (#203801)\n\n## Summary\r\n\r\n-
Handle params in \"identifier pattern\" parser nodes.\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"df16472e910c2c5d7883931ef0630582c7c9edd2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.18.0"],"title":"[ES|QL]
Fix param parsing in qualified name identifier pattern
nodes","number":203801,"url":"https://github.com/elastic/kibana/pull/203801","mergeCommit":{"message":"[ES|QL]
Fix param parsing in qualified name (#203801)\n\n## Summary\r\n\r\n-
Handle params in \"identifier pattern\" parser nodes.\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"df16472e910c2c5d7883931ef0630582c7c9edd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203801","number":203801,"mergeCommit":{"message":"[ES|QL]
Fix param parsing in qualified name (#203801)\n\n## Summary\r\n\r\n-
Handle params in \"identifier pattern\" parser nodes.\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"df16472e910c2c5d7883931ef0630582c7c9edd2"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vadim Kibana <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@vadimkibana @CAWilson94
[ES|QL] Fix param parsing in qualified name (elastic#203801)
3307710 
## Summary

- Handle params in "identifier pattern" parser nodes.


### Checklist


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadimkibana @elasticmachine @kibanamachine @stratoula