-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Removing ignore_throttled from anomaly detection job results searches #203788
Merged
jgowdyelastic
merged 3 commits into
elastic:main
from
jgowdyelastic:removing-ignore_throttled-from-datafeed-results-searh
Dec 13, 2024
Merged
[ML] Removing ignore_throttled from anomaly detection job results searches #203788
jgowdyelastic
merged 3 commits into
elastic:main
from
jgowdyelastic:removing-ignore_throttled-from-datafeed-results-searh
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
chore
:ml
Feature:Anomaly Detection
ML anomaly detection
v9.0.0
v8.18.0
release_note:fix
and removed
chore
labels
Dec 11, 2024
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
changed the title
[ML] Removing ignore_throttled from datafeed results search
[ML] Removing ignore_throttled from anomaly detection job results search
Dec 11, 2024
jgowdyelastic
changed the title
[ML] Removing ignore_throttled from anomaly detection job results search
[ML] Removing ignore_throttled from anomaly detection job results searches
Dec 11, 2024
peteharverson
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12313022396 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2024
…rches (elastic#203788) `ignore_throttled` is automatically added to AD jobs when created. These are then reused in various searches where the whole `indices_options` object from the datafeed is passed in the search call. This PR adds a function to remove `ignore_throttled` in these situations to avoid triggering deprecation warnings. (cherry picked from commit a69a456)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2024
…ts searches (#203788) (#204178) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Removing ignore_throttled from anomaly detection job results searches (#203788)](#203788) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T09:27:16Z","message":"[ML] Removing ignore_throttled from anomaly detection job results searches (#203788)\n\n`ignore_throttled` is automatically added to AD jobs when created. These\r\nare then reused in various searches where the whole `indices_options`\r\nobject from the datafeed is passed in the search call.\r\n\r\nThis PR adds a function to remove `ignore_throttled` in these situations\r\nto avoid triggering deprecation warnings.","sha":"a69a456e698d5905753359e6ee10a7b3d1cfbe38","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly Detection","v9.0.0","backport:version","v8.18.0"],"title":"[ML] Removing ignore_throttled from anomaly detection job results searches","number":203788,"url":"https://github.com/elastic/kibana/pull/203788","mergeCommit":{"message":"[ML] Removing ignore_throttled from anomaly detection job results searches (#203788)\n\n`ignore_throttled` is automatically added to AD jobs when created. These\r\nare then reused in various searches where the whole `indices_options`\r\nobject from the datafeed is passed in the search call.\r\n\r\nThis PR adds a function to remove `ignore_throttled` in these situations\r\nto avoid triggering deprecation warnings.","sha":"a69a456e698d5905753359e6ee10a7b3d1cfbe38"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203788","number":203788,"mergeCommit":{"message":"[ML] Removing ignore_throttled from anomaly detection job results searches (#203788)\n\n`ignore_throttled` is automatically added to AD jobs when created. These\r\nare then reused in various searches where the whole `indices_options`\r\nobject from the datafeed is passed in the search call.\r\n\r\nThis PR adds a function to remove `ignore_throttled` in these situations\r\nto avoid triggering deprecation warnings.","sha":"a69a456e698d5905753359e6ee10a7b3d1cfbe38"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:Anomaly Detection
ML anomaly detection
:ml
release_note:fix
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_throttled
is automatically added to AD jobs when created. These are then reused in various searches where the wholeindices_options
object from the datafeed is passed in the search call.This PR adds a function to remove
ignore_throttled
in these situations to avoid triggering deprecation warnings.