Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Removing ignore_throttled from anomaly detection job results searches #203788

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Dec 11, 2024

ignore_throttled is automatically added to AD jobs when created. These are then reused in various searches where the whole indices_options object from the datafeed is passed in the search call.

This PR adds a function to remove ignore_throttled in these situations to avoid triggering deprecation warnings.

@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 11, 2024 13:04
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner December 11, 2024 13:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic marked this pull request as draft December 11, 2024 13:05
@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 11, 2024 13:37
@jgowdyelastic jgowdyelastic changed the title [ML] Removing ignore_throttled from datafeed results search [ML] Removing ignore_throttled from anomaly detection job results search Dec 11, 2024
@jgowdyelastic jgowdyelastic changed the title [ML] Removing ignore_throttled from anomaly detection job results search [ML] Removing ignore_throttled from anomaly detection job results searches Dec 11, 2024
@peteharverson peteharverson added the backport:version Backport to applied version labels label Dec 11, 2024
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit a69a456 into elastic:main Dec 13, 2024
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12313022396

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2024
…rches (elastic#203788)

`ignore_throttled` is automatically added to AD jobs when created. These
are then reused in various searches where the whole `indices_options`
object from the datafeed is passed in the search call.

This PR adds a function to remove `ignore_throttled` in these situations
to avoid triggering deprecation warnings.

(cherry picked from commit a69a456)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 13, 2024
…ts searches (#203788) (#204178)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Removing ignore_throttled from anomaly detection job results
searches (#203788)](#203788)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T09:27:16Z","message":"[ML]
Removing ignore_throttled from anomaly detection job results searches
(#203788)\n\n`ignore_throttled` is automatically added to AD jobs when
created. These\r\nare then reused in various searches where the whole
`indices_options`\r\nobject from the datafeed is passed in the search
call.\r\n\r\nThis PR adds a function to remove `ignore_throttled` in
these situations\r\nto avoid triggering deprecation
warnings.","sha":"a69a456e698d5905753359e6ee10a7b3d1cfbe38","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly
Detection","v9.0.0","backport:version","v8.18.0"],"title":"[ML] Removing
ignore_throttled from anomaly detection job results
searches","number":203788,"url":"https://github.com/elastic/kibana/pull/203788","mergeCommit":{"message":"[ML]
Removing ignore_throttled from anomaly detection job results searches
(#203788)\n\n`ignore_throttled` is automatically added to AD jobs when
created. These\r\nare then reused in various searches where the whole
`indices_options`\r\nobject from the datafeed is passed in the search
call.\r\n\r\nThis PR adds a function to remove `ignore_throttled` in
these situations\r\nto avoid triggering deprecation
warnings.","sha":"a69a456e698d5905753359e6ee10a7b3d1cfbe38"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203788","number":203788,"mergeCommit":{"message":"[ML]
Removing ignore_throttled from anomaly detection job results searches
(#203788)\n\n`ignore_throttled` is automatically added to AD jobs when
created. These\r\nare then reused in various searches where the whole
`indices_options`\r\nobject from the datafeed is passed in the search
call.\r\n\r\nThis PR adds a function to remove `ignore_throttled` in
these situations\r\nto avoid triggering deprecation
warnings.","sha":"a69a456e698d5905753359e6ee10a7b3d1cfbe38"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants