Remove links to Logs Explorer #203685

thomheymann · 2024-12-10T20:06:43Z

Resolves #182229

Release Note

Remove Logs Explorer

Summary

Removes the Discover/Logs Explorer tabs in the top nav
Changes all links to Logs Explorer in other applications to Discover
Removes all APIs exposed by Logs Explorer

Note: This does not remove Logs Explorer from the codebase. There will be a follow up for that work.

…logs-explorer

…fix'

…logs-explorer

…fix'

…logs-explorer

…fix'

…/kibana into remove-logs-explorer

…logs-explorer

…fix'

…/kibana into remove-logs-explorer

elasticmachine · 2024-12-20T21:19:23Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2024-12-20T21:19:23Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine · 2024-12-20T21:19:23Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

github-actions · 2024-12-20T21:19:32Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

jbudz

.buildkite/ftr_oblt_stateful_configs.yml

juliaElastic

Fleet change LGTM

MiriamAparicio

Code review only, changes for @obs-ux-infra_services-team LGTM

…logs-explorer

…-fix'

Bamieh

telemetry schema changes LGTM

davismcphee

Data Discovery changes LGTM and it works as expected, no more Logs Explorer tab 👍

davismcphee · 2025-01-03T04:12:11Z

src/platform/plugins/shared/data_views/common/types.ts

+   * Contrary to its name, this property sets the index pattern of the data view. (e.g. `logs-*,metrics-*`)
+   *
+   * Use the `name` property instead to set a human readable name for the data view.


Oh legacy code... At one point this was both the pattern and display name, but that hasn't been the case in a long time. Makes sense to call it out explicitly.

davismcphee · 2025-01-03T04:17:15Z

...lugins/shared/discover/public/application/main/components/top_nav/discover_topnav_inline.tsx

@@ -39,13 +36,6 @@ export const DiscoverTopNavInline = ({
      css={{ boxShadow: 'none', backgroundColor: euiThemeVars.euiPageBackgroundColor }}
      data-test-subj="discoverTopNavInline"
    >
-      {customizationContext.inlineTopNav.showLogsExplorerTabs && (


This prop can likely be removed now that O11y no longer needs it, but we can handle that as a followup.

…logs-explorer

…/kibana into remove-logs-explorer

Kerry350

Thanks for pushing this through 🙌

elasticmachine · 2025-01-03T12:39:01Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 63ad8d8
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203685-63ad8d8cdbe8

Failed CI Steps

Fleet Cypress Tests #1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1910	1909	-1
`dataQuality`	67	66	-1
`datasetQuality`	273	267	-6
`dataUsage`	120	119	-1
`discover`	928	925	-3
`infra`	1282	1281	-1
`inventory`	238	237	-1
`logsExplorer`	571	567	-4
`logsShared`	379	377	-2
`observability`	1091	1090	-1
`observabilityAIAssistantApp`	418	417	-1
`observabilityLogsExplorer`	192	24	-168
`observabilityOnboarding`	236	232	-4
`observabilityShared`	239	238	-1
`profiling`	291	290	-1
`unifiedDocViewer`	217	216	-1
`uptime`	571	570	-1
`ux`	186	185	-1
total			-199

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/deeplinks-observability`	58	42	-16
`discover`	167	163	-4
`logsExplorer`	120	119	-1
`logsShared`	287	286	-1
`observabilityLogsExplorer`	19	3	-16
total			-38

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	5.6MB	5.6MB	+24.0B
`datasetQuality`	252.5KB	250.5KB	-2.0KB
`discover`	782.3KB	778.0KB	-4.3KB
`fleet`	1.7MB	1.7MB	+68.0B
`infra`	1.3MB	1.3MB	+228.0B
`logsExplorer`	223.1KB	223.2KB	+19.0B
`logsShared`	291.1KB	281.2KB	-9.9KB
`observability`	478.7KB	478.6KB	-152.0B
`observabilityLogsExplorer`	142.1KB	906.0B	-141.2KB
`observabilityOnboarding`	269.9KB	269.8KB	-96.0B
total			-157.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`logsExplorer`	23	22	-1
`logsShared`	34	36	+2
`observabilityLogsExplorer`	1	0	-1
total			-0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`datasetQuality`	18.9KB	18.8KB	-49.0B
`discover`	45.2KB	44.9KB	-263.0B
`fleet`	171.2KB	171.2KB	-20.0B
`infra`	51.0KB	50.6KB	-438.0B
`logsExplorer`	27.6KB	26.6KB	-995.0B
`logsShared`	174.8KB	173.6KB	-1.1KB
`observability`	102.2KB	102.1KB	-168.0B
`observabilityLogsExplorer`	15.0KB	8.5KB	-6.5KB
`observabilityOnboarding`	10.4KB	10.2KB	-201.0B
`serverlessObservability`	29.0KB	28.9KB	-132.0B
total			-9.8KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/deeplinks-observability`	70	43	-27
`discover`	215	210	-5
`logsExplorer`	120	119	-1
`logsShared`	316	315	-1
`observabilityLogsExplorer`	19	3	-16
total			-50

async chunk count

id	before	after	diff
`discover`	28	27	-1
`observabilityLogsExplorer`	6	1	-5
total			-6

ESLint disabled line counts

id	before	after	diff
`@kbn/deeplinks-observability`	11	6	-5
`discover`	18	17	-1
`logsExplorer`	4	5	+1
`observabilityLogsExplorer`	2	3	+1
total			-4

miscellaneous assets size

id	before	after	diff
`observabilityLogsExplorer`	387.0KB	0.0B	-387.0KB

Total ESLint disabled count

id	before	after	diff
`@kbn/deeplinks-observability`	11	6	-5
`discover`	20	19	-1
`logsExplorer`	6	7	+1
`observabilityLogsExplorer`	2	3	+1
total			-4

History

💔 Build #263732 failed 894cfbe
💛 Build #262616 was flaky bbe0a9a
💔 Build #262603 failed 073e614
💔 Build #262465 failed ad4daf5
💔 Build #261608 failed a4f882b

Resolves elastic#182229 ## Release Note Remove Logs Explorer ## Summary - Removes the Discover/Logs Explorer tabs in the top nav - Changes all links to Logs Explorer in other applications to Discover - Removes all APIs exposed by Logs Explorer Note: This does not remove Logs Explorer from the codebase. There will be a follow up for that work. --------- Co-authored-by: kibanamachine <[email protected]>

thomheymann and others added 16 commits December 6, 2024 12:27

Change links to logs to Discover

3983883

Fix imports

3977135

Reduce API surface

dabf64d

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

04df335

…logs-explorer

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

8f5fba1

…fix'

Remove unnecessary dependency

a06b9d9

Fix time range

cce85b4

Fix unit tests

a37a57e

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

5bcff39

…logs-explorer

Fix functional tests

010615b

Remove Logs Explorer from navigation and tabs

c63003b

Fix tests

6334697

More locators

bdf2671

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

5182b95

…logs-explorer

[CI] Auto-commit changed files from 'node scripts/notice'

ef01191

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

ad2bdd8

…fix'

thomheymann changed the title ~~remove logs explorer~~ Remove links to Logs Explorer Dec 13, 2024

thomheymann and others added 13 commits December 13, 2024 16:44

.

9c50d27

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

edae402

…logs-explorer

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

8cdaa03

…fix'

[CI] Auto-commit changed files from 'node scripts/telemetry_check'

764810b

.

88d47ca

Merge branch 'remove-logs-explorer' of https://github.com/thomheymann…

527884f

…/kibana into remove-logs-explorer

.

2e3e8b1

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

ab32193

…logs-explorer

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

3f1640b

…fix'

.

225deac

Merge branch 'remove-logs-explorer' of https://github.com/thomheymann…

ea3d66b

…/kibana into remove-logs-explorer

.

b201571

.

565aa1f

thomheymann requested review from a team as code owners December 20, 2024 16:51

dmlemeshko approved these changes Dec 20, 2024

View reviewed changes

elena-shostak approved these changes Dec 23, 2024

View reviewed changes

jbudz approved these changes Dec 23, 2024

View reviewed changes

juliaElastic approved these changes Dec 24, 2024

View reviewed changes

MiriamAparicio approved these changes Dec 24, 2024

View reviewed changes

shahzad31 approved these changes Jan 2, 2025

View reviewed changes

thomheymann and others added 2 commits January 2, 2025 11:27

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

55f0830

…logs-explorer

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

894cfbe

…-fix'

Bamieh approved these changes Jan 2, 2025

View reviewed changes

davismcphee approved these changes Jan 3, 2025

View reviewed changes

Kerry350 self-requested a review January 3, 2025 10:00

thomheymann added 2 commits January 3, 2025 11:12

Merge branch 'main' of https://github.com/elastic/kibana into remove-…

4e40502

…logs-explorer

Merge branch 'remove-logs-explorer' of https://github.com/thomheymann…

63ad8d8

…/kibana into remove-logs-explorer

Kerry350 approved these changes Jan 3, 2025

View reviewed changes

thomheymann added the backport:skip This commit does not require backporting label Jan 3, 2025

thomheymann merged commit 8902f70 into elastic:main Jan 3, 2025
10 checks passed

wayneseymour mentioned this pull request Jan 15, 2025

[FLAKY ON MKI] x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_details.ts #206734

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove links to Logs Explorer #203685

Remove links to Logs Explorer #203685

thomheymann commented Dec 10, 2024 •

edited

Loading

elasticmachine commented Dec 20, 2024

elasticmachine commented Dec 20, 2024

elasticmachine commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

jbudz left a comment

juliaElastic left a comment

MiriamAparicio left a comment

Bamieh left a comment

davismcphee left a comment

davismcphee Jan 3, 2025

davismcphee Jan 3, 2025

Kerry350 left a comment

elasticmachine commented Jan 3, 2025 •

edited

Loading

API count

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

Remove links to Logs Explorer #203685

Remove links to Logs Explorer #203685

Conversation

thomheymann commented Dec 10, 2024 • edited Loading

Release Note

Summary

elasticmachine commented Dec 20, 2024

elasticmachine commented Dec 20, 2024

elasticmachine commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

🤖 GitHub comments

jbudz left a comment

Choose a reason for hiding this comment

juliaElastic left a comment

Choose a reason for hiding this comment

MiriamAparicio left a comment

Choose a reason for hiding this comment

Bamieh left a comment

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

davismcphee Jan 3, 2025

Choose a reason for hiding this comment

davismcphee Jan 3, 2025

Choose a reason for hiding this comment

Kerry350 left a comment

Choose a reason for hiding this comment

elasticmachine commented Jan 3, 2025 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

History

thomheymann commented Dec 10, 2024 •

edited

Loading

elasticmachine commented Jan 3, 2025 •

edited

Loading