[Fleet] Fix changing space for agent actions #203683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge |
|
@elasticmachine merge upstream |
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
cc @nchaulet |
| searchAfter = lastAgent.sort; | ||
|
|
||
| await esClient.updateByQuery({ | ||
| index: AGENT_ACTIONS_INDEX, |
There was a problem hiding this comment.
we don't store spaces in .fleet-actions-results, right? so that doesn't have to be updated
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12297328678 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit 8d5cd4f) # Conflicts: # x-pack/plugins/fleet/server/services/spaces/agent_policy.ts
nchaulet
added a commit
that referenced
this pull request
Dec 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Fix changing space for agent actions (#203683)](#203683) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T13:23:50Z","message":"[Fleet] Fix changing space for agent actions (#203683)","sha":"8d5cd4f2d752a8d47c37225c91561af3763464d3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"number":203683,"url":"https://github.com/elastic/kibana/pull/203683","mergeCommit":{"message":"[Fleet] Fix changing space for agent actions (#203683)","sha":"8d5cd4f2d752a8d47c37225c91561af3763464d3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203683","number":203683,"mergeCommit":{"message":"[Fleet] Fix changing space for agent actions (#203683)","sha":"8d5cd4f2d752a8d47c37225c91561af3763464d3"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #194931
When reassigning a policy to different spaces we were not reassigning action that PR fix it.
How to test
Enable space awareness (feature flag + API call)
Create agent action in a space and update the policy spaces, it should update the action spaces, too and action should be visible in agent activity of the newly assigned space.