[Index management] Fix a11y focus order in index mappings page #203361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saarikabhasi
changed the title
saarikabhasi
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
|
mattkime
approved these changes
Dec 10, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12259702079 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…ic#203361) ## Summary Fix a11y focus order in index mappings page. When new field is in pending state and after closing edit pending field Flyout. https://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771 ### Test instructions #### Adding a field 1. Add new field in index mappings page by navigating via tab 2. Notice that type fields combo box is focused 3. Add field and click to Add field button again with in pending fields form 4. Notice focus is on new create field form #### Edit field in pending state 1. Add new fields via tab key 2. click on edit field 3. Try closing, updating and cancelling in the edit field flyout form 4. Notice after edit field flyout is closed, focus is on the pending fields form (cherry picked from commit 4b0c0e9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…ic#203361) ## Summary Fix a11y focus order in index mappings page. When new field is in pending state and after closing edit pending field Flyout. https://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771 ### Test instructions #### Adding a field 1. Add new field in index mappings page by navigating via tab 2. Notice that type fields combo box is focused 3. Add field and click to Add field button again with in pending fields form 4. Notice focus is on new create field form #### Edit field in pending state 1. Add new fields via tab key 2. click on edit field 3. Try closing, updating and cancelling in the edit field flyout form 4. Notice after edit field flyout is closed, focus is on the pending fields form (cherry picked from commit 4b0c0e9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…ic#203361) ## Summary Fix a11y focus order in index mappings page. When new field is in pending state and after closing edit pending field Flyout. https://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771 ### Test instructions #### Adding a field 1. Add new field in index mappings page by navigating via tab 2. Notice that type fields combo box is focused 3. Add field and click to Add field button again with in pending fields form 4. Notice focus is on new create field form #### Edit field in pending state 1. Add new fields via tab key 2. click on edit field 3. Try closing, updating and cancelling in the edit field flyout form 4. Notice after edit field flyout is closed, focus is on the pending fields form (cherry picked from commit 4b0c0e9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…ic#203361) ## Summary Fix a11y focus order in index mappings page. When new field is in pending state and after closing edit pending field Flyout. https://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771 ### Test instructions #### Adding a field 1. Add new field in index mappings page by navigating via tab 2. Notice that type fields combo box is focused 3. Add field and click to Add field button again with in pending fields form 4. Notice focus is on new create field form #### Edit field in pending state 1. Add new fields via tab key 2. click on edit field 3. Try closing, updating and cancelling in the edit field flyout form 4. Notice after edit field flyout is closed, focus is on the pending fields form (cherry picked from commit 4b0c0e9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…#203361) (#203625) # Backport This will backport the following commits from `main` to `8.15`: - [[Index management] Fix a11y focus order in index mappings page (#203361)](#203361) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:46:20Z","message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Index management] Fix a11y focus order in index mappings page ","number":203361,"url":"https://github.com/elastic/kibana/pull/203361","mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203361","number":203361,"mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…#203361) (#203627) # Backport This will backport the following commits from `main` to `8.17`: - [[Index management] Fix a11y focus order in index mappings page (#203361)](#203361) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:46:20Z","message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Index management] Fix a11y focus order in index mappings page ","number":203361,"url":"https://github.com/elastic/kibana/pull/203361","mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203361","number":203361,"mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…#203361) (#203626) # Backport This will backport the following commits from `main` to `8.16`: - [[Index management] Fix a11y focus order in index mappings page (#203361)](#203361) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:46:20Z","message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Index management] Fix a11y focus order in index mappings page ","number":203361,"url":"https://github.com/elastic/kibana/pull/203361","mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203361","number":203361,"mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…203361) (#203628) # Backport This will backport the following commits from `main` to `8.x`: - [[Index management] Fix a11y focus order in index mappings page (#203361)](#203361) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:46:20Z","message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Index management] Fix a11y focus order in index mappings page ","number":203361,"url":"https://github.com/elastic/kibana/pull/203361","mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203361","number":203361,"mergeCommit":{"message":"[Index management] Fix a11y focus order in index mappings page (#203361)\n\n## Summary\r\n\r\nFix a11y focus order in index mappings page. When new field is in\r\npending state and after closing edit pending field Flyout.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771\r\n\r\n### Test instructions \r\n#### Adding a field\r\n1. Add new field in index mappings page by navigating via tab \r\n2. Notice that type fields combo box is focused\r\n3. Add field and click to Add field button again with in pending fields\r\nform\r\n4. Notice focus is on new create field form\r\n\r\n#### Edit field in pending state\r\n1. Add new fields via tab key\r\n2. click on edit field \r\n3. Try closing, updating and cancelling in the edit field flyout form\r\n4. Notice after edit field flyout is closed, focus is on the pending\r\nfields form","sha":"4b0c0e92693ad759e3ce45b4b259c9908ddd0d51"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ic#203361) ## Summary Fix a11y focus order in index mappings page. When new field is in pending state and after closing edit pending field Flyout. https://github.com/user-attachments/assets/dbdf59e5-0ebd-47e0-9b5e-19ab1556e771 ### Test instructions #### Adding a field 1. Add new field in index mappings page by navigating via tab 2. Notice that type fields combo box is focused 3. Add field and click to Add field button again with in pending fields form 4. Notice focus is on new create field form #### Edit field in pending state 1. Add new fields via tab key 2. click on edit field 3. Try closing, updating and cancelling in the edit field flyout form 4. Notice after edit field flyout is closed, focus is on the pending fields form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a11y focus order in index mappings page. When new field is in pending state and after closing edit pending field Flyout.
focus.order.a11y.index.mappings.mov
Test instructions
Adding a field
Edit field in pending state