Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix missing embeddable panel titles #203355

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[Lens] Fix missing embeddable panel titles #203355

merged 4 commits into from
Dec 10, 2024

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Dec 7, 2024 •
edited by kibanamachine
Loading

Summary

When using the new Custom Lens embeddable component, the titles are hidden by default due to to a regression introduced in #186642.
This PR should fix the correct title handling of the header visibility by hiding or showing the wrapping Panel title depending on the hidePanelTitles props of the LensRenderer component

fix #203354

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Feature:Embeddables Relating to the Embeddable system backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Dec 7, 2024
@markov00 markov00 marked this pull request as ready for review December 7, 2024 21:50
@markov00 markov00 requested a review from a team as a code owner December 7, 2024 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 requested a review from a team December 9, 2024 07:59
MiriamAparicio
MiriamAparicio approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@nreese nreese self-requested a review December 9, 2024 14:57
nreese
nreese approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage of PublishesPanelTitle interface LGTM
code review only

nickofthyme
nickofthyme approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fix locally 👍🏼 .

x-pack/plugins/lens/public/react_embeddable/renderer/lens_custom_renderer_component.tsx Show resolved Hide resolved
@markov00 markov00 enabled auto-merge (squash) December 10, 2024 07:56
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 10, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / Observability AI Assistant API tests public_complete/public_complete.spec.ts /api/observability_ai_assistant/chat/complete after executing an action closes the stream without persisting the conversation
  • [job] [logs] FTR Configs #49 / Observability AI Assistant API tests public_complete/public_complete.spec.ts /api/observability_ai_assistant/chat/complete after executing an action closes the stream without persisting the conversation

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 49.9KB 50.0KB +28.0B

History

@markov00 markov00 merged commit 6e57a23 into elastic:main Dec 10, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12259574288

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
@markov00
[Lens] Fix missing embeddable panel titles (elastic#203355)
9baed7c 
## Summary

When using the new Custom Lens embeddable component, the titles are
hidden by default due to to a regression introduced in
elastic#186642.
This PR should fix the correct title handling of the header visibility
by hiding or showing the wrapping Panel title depending on the
`hidePanelTitles` props of the `LensRenderer` component

fix elastic#203354

(cherry picked from commit 6e57a23)
@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
@kibanamachine @markov00
[8.x] [Lens] Fix missing embeddable panel titles (#203355) (#203621)
85f8a4b 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] Fix missing embeddable panel titles
(#203355)](#203355)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:39:15Z","message":"[Lens]
Fix missing embeddable panel titles (#203355)\n\n## Summary\r\n\r\nWhen
using the new Custom Lens embeddable component, the titles are\r\nhidden
by default due to to a regression introduced
in\r\nhttps://github.com//pull/186642.\r\nThis PR should
fix the correct title handling of the header visibility\r\nby hiding or
showing the wrapping Panel title depending on the\r\n`hidePanelTitles`
props of the `LensRenderer` component\r\n\r\n\r\nfix
https://github.com/elastic/kibana/issues/203354","sha":"6e57a23d18d949e7ac3118c1f27550e2ba9eedf8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor","Feature:Embeddables"],"title":"[Lens]
Fix missing embeddable panel
titles","number":203355,"url":"https://github.com/elastic/kibana/pull/203355","mergeCommit":{"message":"[Lens]
Fix missing embeddable panel titles (#203355)\n\n## Summary\r\n\r\nWhen
using the new Custom Lens embeddable component, the titles are\r\nhidden
by default due to to a regression introduced
in\r\nhttps://github.com//pull/186642.\r\nThis PR should
fix the correct title handling of the header visibility\r\nby hiding or
showing the wrapping Panel title depending on the\r\n`hidePanelTitles`
props of the `LensRenderer` component\r\n\r\n\r\nfix
https://github.com/elastic/kibana/issues/203354","sha":"6e57a23d18d949e7ac3118c1f27550e2ba9eedf8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203355","number":203355,"mergeCommit":{"message":"[Lens]
Fix missing embeddable panel titles (#203355)\n\n## Summary\r\n\r\nWhen
using the new Custom Lens embeddable component, the titles are\r\nhidden
by default due to to a regression introduced
in\r\nhttps://github.com//pull/186642.\r\nThis PR should
fix the correct title handling of the header visibility\r\nby hiding or
showing the wrapping Panel title depending on the\r\n`hidePanelTitles`
props of the `LensRenderer` component\r\n\r\n\r\nfix
https://github.com/elastic/kibana/issues/203354","sha":"6e57a23d18d949e7ac3118c1f27550e2ba9eedf8"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>
@markov00 markov00 deleted the 2024_12_07-fix_missing_embeddable_titles branch December 10, 2024 18:07
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@markov00 @CAWilson94
[Lens] Fix missing embeddable panel titles (elastic#203355)
6fcdee0 
## Summary

When using the new Custom Lens embeddable component, the titles are
hidden by default due to to a regression introduced in
elastic#186642.
This PR should fix the correct title handling of the header visibility
by hiding or showing the wrapping Panel title depending on the
`hidePanelTitles` props of the `LensRenderer` component


fix elastic#203354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Embeddables Relating to the Embeddable system Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra] Inventory Host page doesn't show chart titles
7 participants
@markov00 @elasticmachine @kibanamachine @nreese @jennypavlova @nickofthyme @MiriamAparicio