Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops][Task Manager] Deprecating xpack.task_manager.claim_strategy config #203341

Merged
merged 7 commits into from
Dec 12, 2024
Merged

[Response Ops][Task Manager] Deprecating xpack.task_manager.claim_strategy config #203341

merged 7 commits into from
Dec 12, 2024

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Dec 6, 2024 •
edited
Loading

Resolves #202492

Summary

For 9.0 only. Deprecates xpack.task_manager.claim_strategy configuration. Logs warning if value is explicitly set. This value was never added to the Kibana docs in docs/settings/task-manager-settings.asciidoc so nothing to remove there.

To Verify

Set xpack.task_manager.claim_strategy config in kibana.dev.yml and start Kibana. See warning get logged.

@ymao1 ymao1 changed the title [Response Ops][Task Manager] Deprecating xpack.task_manager.claim_strategy config [Response Ops][Task Manager] Deprecating xpack.task_manager.claim_strategy config Dec 6, 2024
@ymao1 ymao1 self-assigned this Dec 6, 2024
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 labels Dec 6, 2024
@ymao1
Copy link
Contributor Author

ymao1 commented Dec 6, 2024

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 7, 2024

@elasticmachine merge upstream

@ymao1 ymao1 marked this pull request as ready for review December 8, 2024 17:42
@ymao1 ymao1 requested a review from a team as a code owner December 8, 2024 17:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 requested review from pmuellr and adcoelho December 8, 2024 17:42
pmuellr
pmuellr approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 11, 2024

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 11, 2024

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 12, 2024

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 12, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / Entity Manager _search API includes source and additional metadata fields

Metrics [docs]

✅ unchanged

History

cc @ymao1

@ymao1 ymao1 merged commit 10771a1 into elastic:main Dec 12, 2024
8 checks passed
@ymao1 ymao1 deleted the ro-202492 branch December 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@adcoelho adcoelho Awaiting requested review from adcoelho

Assignees

@ymao1 ymao1

Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate the xpack.task_manager.claim_strategy setting
3 participants
@ymao1 @elasticmachine @pmuellr