[Search][a11y] Fix table row screen reader error #203136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
|
joemcelroy
approved these changes
Dec 5, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12196060124 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers. (cherry picked from commit 1a9893b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers. (cherry picked from commit 1a9893b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers. (cherry picked from commit 1a9893b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers. (cherry picked from commit 1a9893b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 6, 2024
…3219) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][a11y] Fix table row screen reader error (#203136)](#203136) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T09:10:26Z","message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major"],"title":"[Search][a11y] Fix table row screen reader error","number":203136,"url":"https://github.com/elastic/kibana/pull/203136","mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203136","number":203136,"mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}}]}] BACKPORT--> Co-authored-by: Navarone Feekery <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 6, 2024
…03217) # Backport This will backport the following commits from `main` to `8.16`: - [[Search][a11y] Fix table row screen reader error (#203136)](#203136) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T09:10:26Z","message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major"],"title":"[Search][a11y] Fix table row screen reader error","number":203136,"url":"https://github.com/elastic/kibana/pull/203136","mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203136","number":203136,"mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}}]}] BACKPORT--> Co-authored-by: Navarone Feekery <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 6, 2024
…03216) # Backport This will backport the following commits from `main` to `8.15`: - [[Search][a11y] Fix table row screen reader error (#203136)](#203136) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T09:10:26Z","message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major"],"title":"[Search][a11y] Fix table row screen reader error","number":203136,"url":"https://github.com/elastic/kibana/pull/203136","mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203136","number":203136,"mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}}]}] BACKPORT--> Co-authored-by: Navarone Feekery <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 6, 2024
…03218) # Backport This will backport the following commits from `main` to `8.17`: - [[Search][a11y] Fix table row screen reader error (#203136)](#203136) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T09:10:26Z","message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major"],"title":"[Search][a11y] Fix table row screen reader error","number":203136,"url":"https://github.com/elastic/kibana/pull/203136","mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203136","number":203136,"mergeCommit":{"message":"[Search][a11y] Fix table row screen reader error (#203136)\n\n## Closes https://github.com/elastic/kibana/issues/199113\r\n\r\nAllows errors in the table row to be read by screen readers.","sha":"1a9893bd6f7fd3fb94b08459e05921a00d86b8c5"}}]}] BACKPORT--> Co-authored-by: Navarone Feekery <[email protected]>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Dec 7, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Closes elastic#199113 Allows errors in the table row to be read by screen readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199113
Allows errors in the table row to be read by screen readers.
Screen.Recording.2024-12-05.at.17.16.01.mov