-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page #203093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, was able to reproduce the error on main
and the fix in this PR.
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Thanks for spotting this @benakansara
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested with Custom threshold and Log threshold alert detail pages where Log rate analysis used, the error is not shown anymore.
I will forward thanks to @shahzad31 who initially spotted this error. 🙂 |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12196288966 |
…elastic#203093) ## Summary Fix for: [elastic#203067](elastic#203067) (cherry picked from commit 73b7a90)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…s Page (#203093) (#203221) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page (#203093)](#203093) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T09:26:16Z","message":"[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page (#203093)\n\n## Summary\r\n\r\nFix for: [#203067](https://github.com/elastic/kibana/issues/203067)","sha":"73b7a90a8753d3d86fe43664e255fdd037f8f31d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page","number":203093,"url":"https://github.com/elastic/kibana/pull/203093","mergeCommit":{"message":"[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page (#203093)\n\n## Summary\r\n\r\nFix for: [#203067](https://github.com/elastic/kibana/issues/203067)","sha":"73b7a90a8753d3d86fe43664e255fdd037f8f31d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203093","number":203093,"mergeCommit":{"message":"[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page (#203093)\n\n## Summary\r\n\r\nFix for: [#203067](https://github.com/elastic/kibana/issues/203067)","sha":"73b7a90a8753d3d86fe43664e255fdd037f8f31d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Summary
Fix for: #203067