Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page #203093

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Dec 5, 2024

Summary

Fix for: #203067

@rbrtj rbrtj added release_note:fix v9.0.0 Team:ML Team label for ML (also use :ml) backport:version Backport to applied version labels v8.17.0 labels Dec 5, 2024
@rbrtj rbrtj self-assigned this Dec 5, 2024
@rbrtj rbrtj requested a review from a team as a code owner December 5, 2024 12:17
@rbrtj rbrtj added v8.18.0 and removed v8.17.0 labels Dec 5, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 613.9KB 613.9KB +32.0B

cc @rbrtj

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was able to reproduce the error on main and the fix in this PR.

@rbrtj rbrtj requested a review from benakansara December 5, 2024 14:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Thanks for spotting this @benakansara

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with Custom threshold and Log threshold alert detail pages where Log rate analysis used, the error is not shown anymore.

@benakansara
Copy link
Contributor

Code LGTM. Thanks for spotting this @benakansara

I will forward thanks to @shahzad31 who initially spotted this error. 🙂

@rbrtj rbrtj merged commit 73b7a90 into elastic:main Dec 6, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12196288966

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 6, 2024
…s Page (#203093) (#203221)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page
(#203093)](#203093)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T09:26:16Z","message":"[ML]
AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page
(#203093)\n\n## Summary\r\n\r\nFix for:
[#203067](https://github.com/elastic/kibana/issues/203067)","sha":"73b7a90a8753d3d86fe43664e255fdd037f8f31d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML]
AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts
Page","number":203093,"url":"https://github.com/elastic/kibana/pull/203093","mergeCommit":{"message":"[ML]
AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page
(#203093)\n\n## Summary\r\n\r\nFix for:
[#203067](https://github.com/elastic/kibana/issues/203067)","sha":"73b7a90a8753d3d86fe43664e255fdd037f8f31d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203093","number":203093,"mergeCommit":{"message":"[ML]
AiOps: Fix Log Rate Analysis Embeddable Error on the Alerts Page
(#203093)\n\n## Summary\r\n\r\nFix for:
[#203067](https://github.com/elastic/kibana/issues/203067)","sha":"73b7a90a8753d3d86fe43664e255fdd037f8f31d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
markov00 pushed a commit to markov00/kibana that referenced this pull request Dec 7, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels :ml release_note:fix Team:ML Team label for ML (also use :ml) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants