Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting #203046

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 5, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

2 packages(s) are going to be relocated:

Id Target folder
@kbn/data-stream-adapter x-pack/solutions/security/packages/kbn-data-stream-adapter
@kbn/index-adapter x-pack/solutions/security/packages/kbn-index-adapter
Updated references
./.eslintrc.js
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/plugins/elastic_assistant/tsconfig.type_check.json
./x-pack/plugins/security_solution/tsconfig.type_check.json
./x-pack/solutions/security/packages/kbn-data-stream-adapter/jest.config.js
./x-pack/solutions/security/packages/kbn-index-adapter/jest.config.js
./yarn.lock
Updated relative paths
x-pack/solutions/security/packages/kbn-data-stream-adapter/jest.config.js:12
x-pack/solutions/security/packages/kbn-data-stream-adapter/tsconfig.json:2
x-pack/solutions/security/packages/kbn-data-stream-adapter/tsconfig.type_check.json:2
x-pack/solutions/security/packages/kbn-data-stream-adapter/tsconfig.type_check.json:20
x-pack/solutions/security/packages/kbn-index-adapter/jest.config.js:12
x-pack/solutions/security/packages/kbn-index-adapter/tsconfig.json:2
x-pack/solutions/security/packages/kbn-index-adapter/tsconfig.type_check.json:2
x-pack/solutions/security/packages/kbn-index-adapter/tsconfig.type_check.json:20

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 5, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 5, 2024 05:37
@gsoldevila gsoldevila requested review from a team as code owners December 5, 2024 05:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-security-threat-hunting branch from 88ba31b to 764bb32 Compare December 10, 2024 15:38
@PhilippeOberti PhilippeOberti force-pushed the kbn-team-1309-move-security-threat-hunting branch from d4ba2e2 to 7cc85d2 Compare December 12, 2024 22:34
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desk tested and code LGTM!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / DeleteAttachmentConfirmationModal calls onConfirm

Metrics [docs]

✅ unchanged

History

@PhilippeOberti PhilippeOberti merged commit a9f076c into elastic:main Dec 13, 2024
8 checks passed
@PhilippeOberti PhilippeOberti added v8.18.0 backport:version Backport to applied version labels and removed backport:skip This commit does not require backporting labels Dec 13, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12309614864

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12309614865

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-investigations (#202855)
- [Synthetics] migrate first set of tests (#198950)
- [Obs UX Management] Migrate leftover code owner !! (#203814)
- Sustainable Kibana Architecture: Add scripts/relocate CLI (beta) (#203803)
- [UA] kibana-core ownership (#203410)
- [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 203046

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-investigations (#202855)
- [Synthetics] migrate first set of tests (#198950)
- [Obs UX Management] Migrate leftover code owner !! (#203814)
- Sustainable Kibana Architecture: Add scripts/relocate CLI (beta) (#203803)
- [UA] kibana-core ownership (#203410)
- [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 203046

Questions ?

Please refer to the Backport tool documentation

@PhilippeOberti
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

PhilippeOberti added a commit that referenced this pull request Dec 13, 2024
…c/security-threat-hunting` (#203046) (#204169)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting`
(#203046)](#203046)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T04:29:21Z","message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting` (#203046)\n\n## Summary\r\n\r\nThis
PR aims at relocating some of the Kibana modules (plugins
and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n#### 2 packages(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/data-stream-adapter`
|\r\n`x-pack/solutions/security/packages/kbn-data-stream-adapter` |\r\n|
`@kbn/index-adapter`
|\r\n`x-pack/solutions/security/packages/kbn-index-adapter`
|\r\n\r\n---------\r\n\r\nCo-authored-by: PhilippeOberti
<[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a9f076cb1f73fb6b4045f3218e9181e424625b29","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team:Threat
Hunting","backport:version","v8.18.0"],"number":203046,"url":"https://github.com/elastic/kibana/pull/203046","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting` (#203046)\n\n## Summary\r\n\r\nThis
PR aims at relocating some of the Kibana modules (plugins
and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n#### 2 packages(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/data-stream-adapter`
|\r\n`x-pack/solutions/security/packages/kbn-data-stream-adapter` |\r\n|
`@kbn/index-adapter`
|\r\n`x-pack/solutions/security/packages/kbn-index-adapter`
|\r\n\r\n---------\r\n\r\nCo-authored-by: PhilippeOberti
<[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a9f076cb1f73fb6b4045f3218e9181e424625b29"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203046","number":203046,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting` (#203046)\n\n## Summary\r\n\r\nThis
PR aims at relocating some of the Kibana modules (plugins
and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n#### 2 packages(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/data-stream-adapter`
|\r\n`x-pack/solutions/security/packages/kbn-data-stream-adapter` |\r\n|
`@kbn/index-adapter`
|\r\n`x-pack/solutions/security/packages/kbn-index-adapter`
|\r\n\r\n---------\r\n\r\nCo-authored-by: PhilippeOberti
<[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"a9f076cb1f73fb6b4045f3218e9181e424625b29"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants