Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add rule upgrade review cache invalidation #202969

Merged
merged 2 commits into from
Dec 5, 2024
Merged

[Security Solution] Add rule upgrade review cache invalidation #202969

merged 2 commits into from
Dec 5, 2024
+4 −0

Conversation

xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Dec 4, 2024 •
edited by kibanamachine
Loading

Resolves: #202779

Summary

Implemented proper cache invalidation after rule CRUD operations to prevent displaying stale data in rule upgrade flyouts. See the linked issue for more details.

How to Test

  1. Ensure rule customization is enabled
  2. Navigate to the Rule Updates page
  3. Locate any rule with updates
  4. Make changes to the rule:
    • Edit the rule via the Rule Editing page
    • Use bulk actions
    • Delete the rule
  5. Return to the Rule Updates page
    • All introduced changes should be reflected:
      • Modifications should be visible
      • If the rule was deleted, it should no longer appear on the page

@xcrzx xcrzx added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team backport:version Backport to applied version labels v8.18.0 labels Dec 4, 2024
@xcrzx xcrzx self-assigned this Dec 4, 2024
@xcrzx xcrzx requested a review from a team as a code owner December 4, 2024 15:57
@xcrzx xcrzx requested a review from maximpn December 4, 2024 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

maximpn
maximpn approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xcrzx Thanks for fixing this bug 🙏 Prebuilt rule customization workflow testing won't require page reload with this fix 🎉

Tested locally and got expected rule changes in the rule upgrade flyout.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.6MB 14.6MB +1.6KB

History

cc @xcrzx

@xcrzx xcrzx merged commit 94c5614 into elastic:main Dec 5, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12180681907

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2024
@xcrzx
[Security Solution] Add rule upgrade review cache invalidation (elast…
58a89c9 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page

(cherry picked from commit 94c5614)
@kibanamachine kibanamachine mentioned this pull request Dec 5, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 5, 2024
@kibanamachine @xcrzx
[8.x] [Security Solution] Add rule upgrade review cache invalidation (#…
f0eb7fc 
…202969) (#203102)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Add rule upgrade review cache invalidation
(#202969)](#202969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dmitrii
Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T13:25:35Z","message":"[Security
Solution] Add rule upgrade review cache invalidation
(#202969)\n\n**Resolves:
https://github.com/elastic/kibana/issues/202779**\r\n\r\n##
Summary\r\n\r\nImplemented proper cache invalidation after rule CRUD
operations to\r\nprevent displaying stale data in rule upgrade flyouts.
See the linked\r\nissue for more details.\r\n\r\n### How to
Test\r\n\r\n1. Ensure rule customization is enabled\r\n2. Navigate to
the Rule Updates page \r\n3. Locate any rule with updates\r\n4. Make
changes to the rule:\r\n - Edit the rule via the Rule Editing page\r\n -
Use bulk actions\r\n - Delete the rule\r\n5. Return to the Rule Updates
page\r\n - All introduced changes should be reflected:\r\n -
Modifications should be visible\r\n - If the rule was deleted, it should
no longer appear on the
page","sha":"94c561436644d3a97e01a2d762a368c6965d0ac1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","backport:version","v8.18.0"],"title":"[Security Solution]
Add rule upgrade review cache
invalidation","number":202969,"url":"https://github.com/elastic/kibana/pull/202969","mergeCommit":{"message":"[Security
Solution] Add rule upgrade review cache invalidation
(#202969)\n\n**Resolves:
https://github.com/elastic/kibana/issues/202779**\r\n\r\n##
Summary\r\n\r\nImplemented proper cache invalidation after rule CRUD
operations to\r\nprevent displaying stale data in rule upgrade flyouts.
See the linked\r\nissue for more details.\r\n\r\n### How to
Test\r\n\r\n1. Ensure rule customization is enabled\r\n2. Navigate to
the Rule Updates page \r\n3. Locate any rule with updates\r\n4. Make
changes to the rule:\r\n - Edit the rule via the Rule Editing page\r\n -
Use bulk actions\r\n - Delete the rule\r\n5. Return to the Rule Updates
page\r\n - All introduced changes should be reflected:\r\n -
Modifications should be visible\r\n - If the rule was deleted, it should
no longer appear on the
page","sha":"94c561436644d3a97e01a2d762a368c6965d0ac1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202969","number":202969,"mergeCommit":{"message":"[Security
Solution] Add rule upgrade review cache invalidation
(#202969)\n\n**Resolves:
https://github.com/elastic/kibana/issues/202779**\r\n\r\n##
Summary\r\n\r\nImplemented proper cache invalidation after rule CRUD
operations to\r\nprevent displaying stale data in rule upgrade flyouts.
See the linked\r\nissue for more details.\r\n\r\n### How to
Test\r\n\r\n1. Ensure rule customization is enabled\r\n2. Navigate to
the Rule Updates page \r\n3. Locate any rule with updates\r\n4. Make
changes to the rule:\r\n - Edit the rule via the Rule Editing page\r\n -
Use bulk actions\r\n - Delete the rule\r\n5. Return to the Rule Updates
page\r\n - All introduced changes should be reflected:\r\n -
Modifications should be visible\r\n - If the rule was deleted, it should
no longer appear on the
page","sha":"94c561436644d3a97e01a2d762a368c6965d0ac1"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dmitrii Shevchenko <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@xcrzx @SoniaSanzV
[Security Solution] Add rule upgrade review cache invalidation (elast…
e265907 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@xcrzx @SoniaSanzV
[Security Solution] Add rule upgrade review cache invalidation (elast…
afe40ca 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@xcrzx @CAWilson94
[Security Solution] Add rule upgrade review cache invalidation (elast…
512eb31 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@xcrzx @Samiul-TheSoccerFan
[Security Solution] Add rule upgrade review cache invalidation (elast…
fcb798e 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
@xcrzx @mykolaharmash
[Security Solution] Add rule upgrade review cache invalidation (elast…
d8bff40 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@xcrzx @CAWilson94
[Security Solution] Add rule upgrade review cache invalidation (elast…
9dce172 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@xcrzx xcrzx

Labels
backport:version Backport to applied version labels Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Stale rule data is displayed in the upgrade flyout
4 participants
@xcrzx @elasticmachine @kibanamachine @maximpn