Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] fixing broken tests #202895

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[Profiling] fixing broken tests #202895

merged 2 commits into from
Dec 4, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Dec 4, 2024 •
edited by kibanamachine
Loading

closes #192697

Screenshot 2024-12-04 at 11 03 06

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 4, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner December 4, 2024 11:04
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes requested a review from a team as a code owner December 4, 2024 11:06
MiriamAparicio
MiriamAparicio approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7552

[✅] Profiling - Cypress: 25/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: efb1469
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202895-efb146933be0

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 406.3KB 406.4KB +104.0B

History

@cauemarcondes cauemarcondes merged commit 683b3f3 into elastic:main Dec 4, 2024
8 checks passed
@cauemarcondes cauemarcondes deleted the profiling-tests-2 branch December 4, 2024 13:12
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12160476090

@cauemarcondes cauemarcondes added v8.18.0 backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 labels Dec 4, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 4, 2024
@cauemarcondes
[Profiling] fixing broken tests (elastic#202895)
cbdb528 
closes elastic#192697

<img width="760" alt="Screenshot 2024-12-04 at 11 03 06"
src="https://github.com/user-attachments/assets/69a57c0e-a99a-4d72-99e6-94f2ba0052e8">

(cherry picked from commit 683b3f3)
@kibanamachine kibanamachine mentioned this pull request Dec 4, 2024
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
@cauemarcondes @hop-dev
[Profiling] fixing broken tests (elastic#202895)
bfb55e6 
closes elastic#192697

<img width="760" alt="Screenshot 2024-12-04 at 11 03 06"
src="https://github.com/user-attachments/assets/69a57c0e-a99a-4d72-99e6-94f2ba0052e8">
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@cauemarcondes @SoniaSanzV
[Profiling] fixing broken tests (elastic#202895)
5e60d0f 
closes elastic#192697

<img width="760" alt="Screenshot 2024-12-04 at 11 03 06"
src="https://github.com/user-attachments/assets/69a57c0e-a99a-4d72-99e6-94f2ba0052e8">
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@cauemarcondes @SoniaSanzV
[Profiling] fixing broken tests (elastic#202895)
d63e25c 
closes elastic#192697

<img width="760" alt="Screenshot 2024-12-04 at 11 03 06"
src="https://github.com/user-attachments/assets/69a57c0e-a99a-4d72-99e6-94f2ba0052e8">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@cauemarcondes @CAWilson94
[Profiling] fixing broken tests (elastic#202895)
398fd0f 
closes elastic#192697

<img width="760" alt="Screenshot 2024-12-04 at 11 03 06"
src="https://github.com/user-attachments/assets/69a57c0e-a99a-4d72-99e6-94f2ba0052e8">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@cauemarcondes @CAWilson94
[Profiling] fixing broken tests (elastic#202895)
b9f1e8c 
closes elastic#192697

<img width="760" alt="Screenshot 2024-12-04 at 11 03 06"
src="https://github.com/user-attachments/assets/69a57c0e-a99a-4d72-99e6-94f2ba0052e8">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@delanni delanni delanni approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: profiling_views/functions.cy.ts
5 participants
@cauemarcondes @kibanamachine @elasticmachine @delanni @MiriamAparicio