-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency ownership for Kibana Management team, part 1 #202776
Conversation
Pinging @elastic/kibana-security (Team:Security) |
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to work on this @legrego, I left few comments let me know what you think
renovate.json
Outdated
{ | ||
"groupName": "@elastic/kibana-management dependencies", | ||
"matchDepNames": [ | ||
"@elastic/request-converter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request-converter
has already been added to renovate.json https://github.com/elastic/kibana/blob/main/renovate.json#L1387 but needs to remain separated from this group as it shouln't be backported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest lgtm, thanks a lot @legrego!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
## Summary This updates our `renovate.json` configuration to mark the Kibana Management team as owners of their set of dependencies.
## Summary This updates our `renovate.json` configuration to mark the Kibana Management team as owners of their set of dependencies.
## Summary This updates our `renovate.json` configuration to mark the Kibana Management team as owners of their set of dependencies.
## Summary This updates our `renovate.json` configuration to mark the Kibana Management team as owners of their set of dependencies.
## Summary This updates our `renovate.json` configuration to mark the Kibana Management team as owners of their set of dependencies.
Summary
This updates our
renovate.json
configuration to mark the Kibana Management team as owners of their set of dependencies.