Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency ownership for Kibana Management team, part 1 #202776

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

legrego
Copy link
Member

@legrego legrego commented Dec 3, 2024

Summary

This updates our renovate.json configuration to mark the Kibana Management team as owners of their set of dependencies.

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes dependencies Pull requests that update a dependency file backport:skip This commit does not require backporting labels Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@legrego legrego enabled auto-merge (squash) December 3, 2024 17:16
@legrego legrego requested a review from a team December 3, 2024 17:19
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to work on this @legrego, I left few comments let me know what you think

renovate.json Show resolved Hide resolved
renovate.json Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
renovate.json Outdated
{
"groupName": "@elastic/kibana-management dependencies",
"matchDepNames": [
"@elastic/request-converter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request-converter has already been added to renovate.json https://github.com/elastic/kibana/blob/main/renovate.json#L1387 but needs to remain separated from this group as it shouln't be backported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate.json Outdated Show resolved Hide resolved
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest lgtm, thanks a lot @legrego!

@legrego legrego merged commit c0b3dac into elastic:main Dec 4, 2024
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / AgentlessPackagePoliciesTable shows loading message when isLoading is true
  • [job] [logs] FTR Configs #92 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Heatmap should convert to Lens if Y-axis is defined, but X-axis is not

Metrics [docs]

✅ unchanged

History

@legrego legrego deleted the renovate/kibana-management-1 branch December 4, 2024 19:57
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Management team as owners of their set of dependencies.
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Management team as owners of their set of dependencies.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Management team as owners of their set of dependencies.
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Management team as owners of their set of dependencies.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Management team as owners of their set of dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants