Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack 5.91.0 → 5.96.1 #202534

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

jeramysoucy
Copy link
Contributor

@jeramysoucy jeramysoucy commented Dec 2, 2024

Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here: #191106

@jeramysoucy jeramysoucy marked this pull request as ready for review December 3, 2024 16:35
@jeramysoucy jeramysoucy requested a review from a team December 3, 2024 16:36
@jeramysoucy jeramysoucy added backport:all-open Backport to all branches that could still receive a release Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0 v8.18.0 labels Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy added the release_note:skip Skip the PR/issue when compiling release notes label Dec 3, 2024
@kc13greiner kc13greiner self-requested a review December 3, 2024 16:51
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one question!

yarn.lock Outdated
version "1.0.5"
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-1.0.5.tgz#a6ce3e556e00fd9895dd872dd172ad0d4bd687f4"
integrity sha512-/kYRxGDLWzHOB7q+wtSUQlFrtcdUccpfy+X+9iMBpHK8QLLhx2wIPYuS5DYtR9Wa/YlZAbIovy7qVdB1Aq6Lyw==
"@types/estree@^1.0.6":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Can @types/estree@^1.0.0 be removed since it should resolve to this entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks, Kurt!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@jeramysoucy jeramysoucy merged commit f8860e9 into elastic:main Dec 4, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 7.17, 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12167754639

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 4, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f8860e9)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15 Backport failed because of merge conflicts
8.16 Backport failed because of merge conflicts
8.17 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 202534

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 4, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Upgrade webpack 5.91.0 → 5.96.1
(#202534)](#202534)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T20:28:12Z","message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","v8.18.0"],"title":"Upgrade
webpack 5.91.0 →
5.96.1","number":202534,"url":"https://github.com/elastic/kibana/pull/202534","mergeCommit":{"message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202534","number":202534,"mergeCommit":{"message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <[email protected]>
jeramysoucy added a commit to jeramysoucy/kibana that referenced this pull request Dec 4, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f8860e9)

# Conflicts:
#	yarn.lock
jeramysoucy added a commit to jeramysoucy/kibana that referenced this pull request Dec 4, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f8860e9)

# Conflicts:
#	yarn.lock
jeramysoucy added a commit to jeramysoucy/kibana that referenced this pull request Dec 4, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f8860e9)

# Conflicts:
#	yarn.lock
@jeramysoucy
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17
8.16
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jeramysoucy added a commit that referenced this pull request Dec 6, 2024
# Backport

This will backport the following commits from `main` to `8.17`:
- [Upgrade webpack 5.91.0 → 5.96.1
(#202534)](#202534)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T20:28:12Z","message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","v8.18.0"],"number":202534,"url":"https://github.com/elastic/kibana/pull/202534","mergeCommit":{"message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202534","number":202534,"mergeCommit":{"message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203016","number":203016,"state":"MERGED","mergeCommit":{"sha":"90cf032400a86f7d216fc7b202bb6c3b4f05645c","message":"[8.x]
Upgrade webpack 5.91.0 → 5.96.1 (#202534) (#203016)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.x`:\n- [Upgrade webpack 5.91.0 →
5.96.1\n(#202534)](https://github.com/elastic/kibana/pull/202534)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jeramy\nSoucy\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-04T20:28:12Z\",\"message\":\"Upgrade\nwebpack
5.91.0 → 5.96.1 (#202534)\\n\\n##
Summary\\r\\n\\r\\nUpgrades\nreferences to webpack5 from v5.91.0 to
v5.96.1\\r\\n\\r\\nA v4 to v5 upgrade\nis being
explored\nhere:\\r\\nhttps://github.com//pull/191106\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"f8860e91cf5e6cc061b0f37e618ca58cfef88028\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Security\",\"release_note:skip\",\"v9.0.0\",\"backport:all-open\",\"v8.18.0\"],\"title\":\"Upgrade\nwebpack
5.91.0
→\n5.96.1\",\"number\":202534,\"url\":\"https://github.com/elastic/kibana/pull/202534\",\"mergeCommit\":{\"message\":\"Upgrade\nwebpack
5.91.0 → 5.96.1 (#202534)\\n\\n##
Summary\\r\\n\\r\\nUpgrades\nreferences to webpack5 from v5.91.0 to
v5.96.1\\r\\n\\r\\nA v4 to v5 upgrade\nis being
explored\nhere:\\r\\nhttps://github.com//pull/191106\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"f8860e91cf5e6cc061b0f37e618ca58cfef88028\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/202534\",\"number\":202534,\"mergeCommit\":{\"message\":\"Upgrade\nwebpack
5.91.0 → 5.96.1 (#202534)\\n\\n##
Summary\\r\\n\\r\\nUpgrades\nreferences to webpack5 from v5.91.0 to
v5.96.1\\r\\n\\r\\nA v4 to v5 upgrade\nis being
explored\nhere:\\r\\nhttps://github.com//pull/191106\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"f8860e91cf5e6cc061b0f37e618ca58cfef88028\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Jeramy Soucy <[email protected]>"}}]}] BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
jeramysoucy added a commit that referenced this pull request Dec 6, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [Upgrade webpack 5.91.0 → 5.96.1
(#202534)](#202534)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T20:28:12Z","message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","v8.18.0"],"number":202534,"url":"https://github.com/elastic/kibana/pull/202534","mergeCommit":{"message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202534","number":202534,"mergeCommit":{"message":"Upgrade
webpack 5.91.0 → 5.96.1 (#202534)\n\n## Summary\r\n\r\nUpgrades
references to webpack5 from v5.91.0 to v5.96.1\r\n\r\nA v4 to v5 upgrade
is being explored
here:\r\nhttps://github.com//pull/191106\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f8860e91cf5e6cc061b0f37e618ca58cfef88028"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203016","number":203016,"state":"MERGED","mergeCommit":{"sha":"90cf032400a86f7d216fc7b202bb6c3b4f05645c","message":"[8.x]
Upgrade webpack 5.91.0 → 5.96.1 (#202534) (#203016)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.x`:\n- [Upgrade webpack 5.91.0 →
5.96.1\n(#202534)](https://github.com/elastic/kibana/pull/202534)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jeramy\nSoucy\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-04T20:28:12Z\",\"message\":\"Upgrade\nwebpack
5.91.0 → 5.96.1 (#202534)\\n\\n##
Summary\\r\\n\\r\\nUpgrades\nreferences to webpack5 from v5.91.0 to
v5.96.1\\r\\n\\r\\nA v4 to v5 upgrade\nis being
explored\nhere:\\r\\nhttps://github.com//pull/191106\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"f8860e91cf5e6cc061b0f37e618ca58cfef88028\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Security\",\"release_note:skip\",\"v9.0.0\",\"backport:all-open\",\"v8.18.0\"],\"title\":\"Upgrade\nwebpack
5.91.0
→\n5.96.1\",\"number\":202534,\"url\":\"https://github.com/elastic/kibana/pull/202534\",\"mergeCommit\":{\"message\":\"Upgrade\nwebpack
5.91.0 → 5.96.1 (#202534)\\n\\n##
Summary\\r\\n\\r\\nUpgrades\nreferences to webpack5 from v5.91.0 to
v5.96.1\\r\\n\\r\\nA v4 to v5 upgrade\nis being
explored\nhere:\\r\\nhttps://github.com//pull/191106\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"f8860e91cf5e6cc061b0f37e618ca58cfef88028\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/202534\",\"number\":202534,\"mergeCommit\":{\"message\":\"Upgrade\nwebpack
5.91.0 → 5.96.1 (#202534)\\n\\n##
Summary\\r\\n\\r\\nUpgrades\nreferences to webpack5 from v5.91.0 to
v5.96.1\\r\\n\\r\\nA v4 to v5 upgrade\nis being
explored\nhere:\\r\\nhttps://github.com//pull/191106\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"f8860e91cf5e6cc061b0f37e618ca58cfef88028\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Jeramy Soucy <[email protected]>"}}]}] BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 9, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 11, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Upgrades references to webpack5 from v5.91.0 to v5.96.1

A v4 to v5 upgrade is being explored here:
elastic#191106

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants