[Security Assistant] Fix animation border color of security AI assistant #202319

KDKHD · 2024-11-29T14:02:30Z

Summary

Resolves: #186135

Changes:

Update border color of animated border of the security AI assistance icon from euiColorPrimary to euiBorderColor.

Old border color:

New border color:

New animated:

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

No

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples

…t side panel

KDKHD · 2024-11-29T14:46:04Z

Note: How far should this change be backported?

KDKHD · 2024-11-29T14:48:15Z

/ci

KDKHD · 2024-12-02T10:42:09Z

Note to self: Need to include new tokens from borealis theme

KDKHD · 2024-12-02T11:51:54Z

x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_animated_icon.tsx

+          top: 0;
+          left: 0;
+          z-index: 0;
+          border: 1px solid ${euiTheme.colors.borderBasePlain};


New border color

KDKHD · 2024-12-02T11:53:36Z

Borealis support lifted from this PR #202393

…-fix'

KDKHD · 2024-12-09T09:03:36Z

@elasticmachine merge upstream

…-fix'

patrykkopycinski

LGTM!

…-fix'

elasticmachine · 2024-12-10T13:42:39Z

💚 Build Succeeded

Buildkite Build
Commit: 6c18ec6

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	14.7MB	14.7MB	+54.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/elastic-assistant`	20	18	-2

Total ESLint disabled count

id	before	after	diff
`@kbn/elastic-assistant`	21	19	-2

History

💔 Build #258608 failed 41912c5
💔 Build #258369 failed d25fc15
💔 Build #258136 failed 67f024d
💚 Build #255990 succeeded 133f5bf
💛 Build #255653 was flaky 03c84b6

kibanamachine · 2024-12-10T13:43:32Z

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12257392660

…ant (elastic#202319) ## Summary **Resolves: elastic#186135 Changes: - Update border color of animated border of the security AI assistance icon from `euiColorPrimary` to `euiBorderColor`. Old border color: <img width="182" alt="image" src="https://github.com/user-attachments/assets/a41a7859-3f9a-488c-bd4f-2ed25a52a481"> New border color: <img width="169" alt="image" src="https://github.com/user-attachments/assets/c7e1fa13-adb0-4014-950f-ae643e4e1d6d"> <img width="347" alt="image" src="https://github.com/user-attachments/assets/8fba05e2-2a5b-48b2-b367-a58162cdaa9e"> New animated: ![Nov-29-2024 13-58-11](https://github.com/user-attachments/assets/2eaaf5a0-9bc2-4d84-9625-11ed7902c2c8) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. No Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [X] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 2818a7c)

kibanamachine · 2024-12-10T13:49:22Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15
✅	8.16
✅	8.17
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-12-11T13:51:07Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

…ant (elastic#202319) ## Summary **Resolves: elastic#186135 Changes: - Update border color of animated border of the security AI assistance icon from `euiColorPrimary` to `euiBorderColor`. Old border color: <img width="182" alt="image" src="https://github.com/user-attachments/assets/a41a7859-3f9a-488c-bd4f-2ed25a52a481"> New border color: <img width="169" alt="image" src="https://github.com/user-attachments/assets/c7e1fa13-adb0-4014-950f-ae643e4e1d6d"> <img width="347" alt="image" src="https://github.com/user-attachments/assets/8fba05e2-2a5b-48b2-b367-a58162cdaa9e"> New animated: ![Nov-29-2024 13-58-11](https://github.com/user-attachments/assets/2eaaf5a0-9bc2-4d84-9625-11ed7902c2c8) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. No Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [X] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

kibanamachine · 2024-12-12T14:49:29Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2024-12-13T15:49:05Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2024-12-16T16:48:44Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

fix border color of icon animation inside of the security AI assistan…

c60f956

…t side panel

KDKHD requested a review from e40pud November 29, 2024 14:09

KDKHD marked this pull request as ready for review November 29, 2024 14:10

KDKHD requested a review from a team as a code owner November 29, 2024 14:10

Merge branch 'main' into bug/assistant-animation-style

03c84b6

KDKHD added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 29, 2024

KDKHD removed the request for review from e40pud November 29, 2024 14:18

Merge branch 'main' into bug/assistant-animation-style

65a7604

KDKHD marked this pull request as draft December 2, 2024 10:42

with support for borealis

e094345

KDKHD commented Dec 2, 2024

View reviewed changes

KDKHD marked this pull request as ready for review December 2, 2024 13:03

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

133f5bf

…-fix'

kibanamachine and others added 2 commits December 9, 2024 10:26

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

67f024d

…-fix'

use global emotion theme type

d25fc15

patrykkopycinski approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'main' into bug/assistant-animation-style

fafb6f7

KDKHD enabled auto-merge (squash) December 10, 2024 09:13

fix failing tests

41912c5

KDKHD disabled auto-merge December 10, 2024 09:57

KDKHD and others added 2 commits December 10, 2024 11:42

lint

2dc44bb

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6c18ec6

…-fix'

KDKHD merged commit 2818a7c into elastic:main Dec 10, 2024
9 checks passed

kibanamachine added the v9.0.0 label Dec 10, 2024

kibanamachine mentioned this pull request Dec 10, 2024

[8.15] [Security Assistant] Fix animation border color of security AI assistant (#202319) #203580

Open

kibanamachine mentioned this pull request Dec 10, 2024

[8.16] [Security Assistant] Fix animation border color of security AI assistant (#202319) #203581

Open

kibanamachine mentioned this pull request Dec 10, 2024

[8.17] [Security Assistant] Fix animation border color of security AI assistant (#202319) #203582

Open

kibanamachine mentioned this pull request Dec 10, 2024

[8.x] [Security Assistant] Fix animation border color of security AI assistant (#202319) #203583

Open

This was referenced Dec 10, 2024

[Search] fix: ensure App Search is used for classic nav link name #203490

Merged

[Security Solution] Fixes exception item comment validation on newline chars \n #202063

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Assistant] Fix animation border color of security AI assistant #202319

[Security Assistant] Fix animation border color of security AI assistant #202319

KDKHD commented Nov 29, 2024 •

edited by kibanamachine

Loading

KDKHD commented Nov 29, 2024

KDKHD commented Nov 29, 2024

KDKHD commented Dec 2, 2024

KDKHD Dec 2, 2024

KDKHD commented Dec 2, 2024

KDKHD commented Dec 9, 2024

patrykkopycinski left a comment

elasticmachine commented Dec 10, 2024

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Dec 10, 2024

kibanamachine commented Dec 10, 2024

kibanamachine commented Dec 11, 2024

kibanamachine commented Dec 12, 2024

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 16, 2024

[Security Assistant] Fix animation border color of security AI assistant #202319

[Security Assistant] Fix animation border color of security AI assistant #202319

Conversation

KDKHD commented Nov 29, 2024 • edited by kibanamachine Loading

Summary

Checklist

Identify risks

KDKHD commented Nov 29, 2024

KDKHD commented Nov 29, 2024

KDKHD commented Dec 2, 2024

KDKHD Dec 2, 2024

Choose a reason for hiding this comment

KDKHD commented Dec 2, 2024

KDKHD commented Dec 9, 2024

patrykkopycinski left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 10, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Dec 10, 2024

kibanamachine commented Dec 10, 2024

💚 All backports created successfully

Questions ?

kibanamachine commented Dec 11, 2024

kibanamachine commented Dec 12, 2024

kibanamachine commented Dec 13, 2024

kibanamachine commented Dec 16, 2024

KDKHD commented Nov 29, 2024 •

edited by kibanamachine

Loading