Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Improve some TS. #202314

Merged
merged 12 commits into from
Dec 5, 2024
Merged

[ML] Improve some TS. #202314

merged 12 commits into from
Dec 5, 2024

Conversation

walterra
Copy link
Contributor

Summary

Checklist

  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.18.0 labels Nov 29, 2024
@walterra walterra requested review from darnautov and rbrtj November 29, 2024 13:48
@walterra walterra self-assigned this Nov 29, 2024
@walterra walterra requested a review from a team as a code owner November 29, 2024 13:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

rbrtj
rbrtj reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@rbrtj rbrtj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

darnautov
darnautov approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 614.8KB 614.8KB +9.0B

History

cc @walterra

@walterra walterra merged commit 5c6c4f4 into elastic:main Dec 5, 2024
8 checks passed
@walterra walterra deleted the ml-fix-ts-errors branch December 5, 2024 16:26
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@walterra @SoniaSanzV
[ML] Improve some TS. (elastic#202314)
0a196b9 
## Summary

- Follow up to elastic#175178 to fix some breaking TS changes after the TS
`v4.9.5` upgrade.
- Follow up to elastic#182344 to replace `any` in `useCallback` with proper
types.
- Fixes elastic#176123.

### Checklist

- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@walterra @SoniaSanzV
[ML] Improve some TS. (elastic#202314)
a44e19b 
## Summary

- Follow up to elastic#175178 to fix some breaking TS changes after the TS
`v4.9.5` upgrade.
- Follow up to elastic#182344 to replace `any` in `useCallback` with proper
types.
- Fixes elastic#176123.

### Checklist

- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@walterra @CAWilson94
[ML] Improve some TS. (elastic#202314)
26de39d 
## Summary

- Follow up to elastic#175178 to fix some breaking TS changes after the TS
`v4.9.5` upgrade.
- Follow up to elastic#182344 to replace `any` in `useCallback` with proper
types.
- Fixes elastic#176123.

### Checklist

- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@walterra @Samiul-TheSoccerFan
[ML] Improve some TS. (elastic#202314)
8075ce2 
## Summary

- Follow up to elastic#175178 to fix some breaking TS changes after the TS
`v4.9.5` upgrade.
- Follow up to elastic#182344 to replace `any` in `useCallback` with proper
types.
- Fixes elastic#176123.

### Checklist

- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
@walterra @mykolaharmash
[ML] Improve some TS. (elastic#202314)
963b195 
## Summary

- Follow up to elastic#175178 to fix some breaking TS changes after the TS
`v4.9.5` upgrade.
- Follow up to elastic#182344 to replace `any` in `useCallback` with proper
types.
- Fixes elastic#176123.

### Checklist

- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@walterra @CAWilson94
[ML] Improve some TS. (elastic#202314)
5a0ca99 
## Summary

- Follow up to elastic#175178 to fix some breaking TS changes after the TS
`v4.9.5` upgrade.
- Follow up to elastic#182344 to replace `any` in `useCallback` with proper
types.
- Fixes elastic#176123.

### Checklist

- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrtj rbrtj rbrtj approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] clean up @ts-expect-error and useCallback failures from typescript v4.9.5 and react 18 upgrade
5 participants
@walterra @elasticmachine @darnautov @rbrtj @kibanamachine