-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Views] Disable scripted field creation in the Data Views management page #202250
Merged
davismcphee
merged 32 commits into
elastic:main
from
davismcphee:davis_disable_scripted_field_creation
Dec 6, 2024
+388
−212
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1af7942
disable scripted field creation
mattkime 5bb4dce
Merge branch 'main' into disable_scripted_field_creation
mattkime bb2ac7d
remove button, add callout, update functional tests
mattkime c396745
remove unused localization
mattkime 3f3dfe8
test fixes
mattkime 9b56eff
test fixes
mattkime 4de4413
fix functional tests and Ãsnapshöts
mattkime aa5130e
add i18n
mattkime b5dac4d
better fallback when scripted field tab isn't available - for functio…
mattkime 65ac465
more functional test fixes
mattkime 4647a32
fix functional test
mattkime b308106
remove period from title
mattkime 909d9c3
update snapshot
mattkime c3bdd04
Merge branch 'main' into disable_scripted_field_creation
mattkime d3ad3cf
Merge branch 'main' into davis_disable_scripted_field_creation
davismcphee 6ee7c25
Update docs and UA copy
davismcphee 33d3d19
Copy fixes
davismcphee 5037ad5
Remove modified translations
davismcphee 6b44a98
Add markdown support to ugprade assistant and updated scripted fields…
davismcphee 662f41b
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 0c06115
Adjust copy
davismcphee b66b159
Merge branch 'main' into davis_disable_scripted_field_creation
davismcphee c937a94
Update docs
davismcphee 9030958
Fix broken test
davismcphee 7b0984c
Add upgrade notes
davismcphee c0b7021
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 9e258da
Cleanup
davismcphee 367119a
Merge branch 'main' into davis_disable_scripted_field_creation
davismcphee 0ab2795
Show data view name when available in UA
davismcphee 1c10e2f
Merge branch 'main' into davis_disable_scripted_field_creation
davismcphee 8334e46
Apply docs PR feedback
davismcphee cf2ff64
Merge branch 'main' into davis_disable_scripted_field_creation
davismcphee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Cleanup
- Loading branch information
commit 9e258daa5cb68c5c3859b03940ff10d9e4177b12
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
..._pattern/scripted_fields_table/components/call_outs/__snapshots__/call_outs.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 11 additions & 2 deletions
13
..._index_pattern/scripted_fields_table/components/header/__snapshots__/header.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, tested and works as expected, no scripted fields in a data view, no tab, just the manual way using the old URL to create a scripted field, which then shows the tab with scripted fields, and no button 🥳
One question, about the deprecation message, previously we showed just a max of 3 data views, but it seems we show them all now? or do I miss something. ... just for the case when there are many data views with scripted fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to only show up to three titles in the message, but included the full list in the corrective actions:
kibana/src/plugins/data_views/server/deprecations/scripted_fields.ts
Lines 64 to 72 in cdb5a2d
I removed the ones from
correctiveActions
and instead put a formatted list in the main message. This could get really long for customers who have many data views with scripted fields, but the alternative is not having access to a full list, so I'm not sure what else we could do here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's how it works, thx, what else we can do? Nothing. Approving 👍