Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RCA] [Events timeline] Show all events #202235

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented Nov 28, 2024

As part of #200799, this PR removes filter (previously the filter was based on any group by field, which was changed to focus only on service.name for kubecon demo) so that all events are shown on events timeline.

@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-management Observability Management User Experience Team labels Nov 28, 2024
@benakansara benakansara self-assigned this Nov 28, 2024
@benakansara benakansara marked this pull request as ready for review November 29, 2024 09:17
@benakansara benakansara requested a review from a team as a code owner November 29, 2024 09:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@fkanout fkanout self-requested a review December 4, 2024 09:44
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@benakansara benakansara enabled auto-merge (squash) December 4, 2024 13:44
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 206643e
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202235-206643ec5358

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 481.8KB 481.6KB -264.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
investigateApp 6.7KB 6.5KB -149.0B

History

cc @benakansara

@benakansara benakansara merged commit 2a7689e into elastic:main Dec 4, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12162355066

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 4, 2024
As part of elastic#200799, this PR
removes filter (previously the filter was based on any group by field,
which was changed to focus only on `service.name` for kubecon demo) so
that all events are shown on events timeline.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Faisal Kanout <[email protected]>
(cherry picked from commit 2a7689e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 5, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Dec 5, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[RCA] [Events timeline] Show all events
(#202235)](#202235)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T14:57:05Z","message":"[RCA]
[Events timeline] Show all events (#202235)\n\nAs part of
#200799, this PR\r\nremoves
filter (previously the filter was based on any group by field,\r\nwhich
was changed to focus only on `service.name` for kubecon demo) so\r\nthat
all events are shown on events
timeline.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Faisal Kanout
<[email protected]>","sha":"2a7689e693424679c6e870b772e8510d9a25dbd0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[RCA]
[Events timeline] Show all
events","number":202235,"url":"https://github.com/elastic/kibana/pull/202235","mergeCommit":{"message":"[RCA]
[Events timeline] Show all events (#202235)\n\nAs part of
#200799, this PR\r\nremoves
filter (previously the filter was based on any group by field,\r\nwhich
was changed to focus only on `service.name` for kubecon demo) so\r\nthat
all events are shown on events
timeline.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Faisal Kanout
<[email protected]>","sha":"2a7689e693424679c6e870b772e8510d9a25dbd0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202235","number":202235,"mergeCommit":{"message":"[RCA]
[Events timeline] Show all events (#202235)\n\nAs part of
#200799, this PR\r\nremoves
filter (previously the filter was based on any group by field,\r\nwhich
was changed to focus only on `service.name` for kubecon demo) so\r\nthat
all events are shown on events
timeline.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Faisal Kanout
<[email protected]>","sha":"2a7689e693424679c6e870b772e8510d9a25dbd0"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 5, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
As part of elastic#200799, this PR
removes filter (previously the filter was based on any group by field,
which was changed to focus only on `service.name` for kubecon demo) so
that all events are shown on events timeline.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Faisal Kanout <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
As part of elastic#200799, this PR
removes filter (previously the filter was based on any group by field,
which was changed to focus only on `service.name` for kubecon demo) so
that all events are shown on events timeline.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Faisal Kanout <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
As part of elastic#200799, this PR
removes filter (previously the filter was based on any group by field,
which was changed to focus only on `service.name` for kubecon demo) so
that all events are shown on events timeline.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Faisal Kanout <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
As part of elastic#200799, this PR
removes filter (previously the filter was based on any group by field,
which was changed to focus only on `service.name` for kubecon demo) so
that all events are shown on events timeline.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Faisal Kanout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants