[ResponseOps][Rules] Validate timezone in rule routes #201508
Draft
+613
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
Team:ResponseOps
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
cnasikas
commented
Nov 24, 2024
|
|
||
| export function validateTimezone(timezone: string) { | ||
| if (moment.tz.names().includes(timezone)) { | ||
| if (moment.tz.zone(timezone) != null) { |
There was a problem hiding this comment.
moment.tz.zone is faster than moment.tz.names().includes.
cnasikas
commented
Nov 24, 2024
| @@ -478,6 +478,38 @@ export default function createAlertTests({ getService }: FtrProviderContext) { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should return 400 if the timezone of an action is not valid', async () => { | |||
There was a problem hiding this comment.
Validation already existed. I added a test to avoid bugs in the future.
cnasikas
commented
Nov 24, 2024
| @@ -182,6 +182,51 @@ export default function createUpdateTests({ getService }: FtrProviderContext) { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should return 400 if the timezone of an action is not valid', async () => { | |||
There was a problem hiding this comment.
Validation already existed. I added a test to avoid bugs in the future.
cnasikas
commented
Nov 24, 2024
There was a problem hiding this comment.
The validations are used only in internal routes.
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
Historycc @cnasikas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds validation only for internal routes that use the
rRuleschema.Checklist