Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Add security configs to API #201439

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

viduni94
Copy link
Contributor

Summary

Problem

The API /internal/observability/assistant/alert_details_contextual_insights does not provide explicit authorization settings.

Solution

Add access privileges to the above API

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 self-assigned this Nov 22, 2024
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@viduni94
Copy link
Contributor Author

/ci

@viduni94 viduni94 force-pushed the add-security-configs-to-contextual-insights-api branch from b6f4cbe to 5ee3017 Compare November 22, 2024 18:14
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 22, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #66 / APM API tests fleet/input_only_package.spec.ts basic no archive APM package policy input only package when ingesting events using the scoped api key the events can be seen on the Service Inventory Page
  • [job] [logs] FTR Configs #80 / Serverless observability API - feature flags Platform security APIs security/authorization available features composite features
  • [job] [logs] FTR Configs #80 / Serverless observability API - feature flags Platform security APIs security/authorization available features composite features

Metrics [docs]

✅ unchanged

History

cc @viduni94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants