[ML] Initialize saved objects on trained model page load #201426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:fix
:ml
v9.0.0
Feature:3rd Party Models
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
Nov 27, 2024
Comment on lines
+52
to
+65
| const { initSavedObjects } = useSavedObjectsApiService(); | ||
|
|
||
| const initSavedObjectsWrapper = useCallback(async () => { | ||
| try { | ||
| await initSavedObjects(); | ||
| } catch (error) { | ||
| // ignore error as user may not have permission to sync | ||
| } | ||
| }, [initSavedObjects]); | ||
|
|
||
| const { context } = useRouteResolver('full', ['canGetTrainedModels'], { | ||
| ...basicResolvers(), | ||
| initSavedObjectsWrapper, | ||
| }); |
There was a problem hiding this comment.
nit: useRouteResolver takes care of preserving refs for provided callbacks:
Suggested change
| const { initSavedObjects } = useSavedObjectsApiService(); | |
| const initSavedObjectsWrapper = useCallback(async () => { | |
| try { | |
| await initSavedObjects(); | |
| } catch (error) { | |
| // ignore error as user may not have permission to sync | |
| } | |
| }, [initSavedObjects]); | |
| const { context } = useRouteResolver('full', ['canGetTrainedModels'], { | |
| ...basicResolvers(), | |
| initSavedObjectsWrapper, | |
| }); | |
| const { initSavedObjects } = useSavedObjectsApiService(); | |
| const { context } = useRouteResolver('full', ['canGetTrainedModels'], { | |
| ...basicResolvers(), | |
| initSavedObjects: () => initSavedObjects().catch(() => {}) | |
| }); |
There was a problem hiding this comment.
This change is neater. I'm currently working on a related change which will do something similar on all ML pages. So for the sake of not having to retest this PR I'm going to merge as is and apply this refactor to the follow up PR
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
jgowdyelastic
deleted the
initialize-saved-objects-on-trained-model-page-load
branch
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12054469470 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
) Fixes elastic#201410 On page load, we now call the saved object initialization api which creates any missing saved objects. (cherry picked from commit 6a649b2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
…) (#202027) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Initialize saved objects on trained model page load (#201426)](#201426) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T16:28:22Z","message":"[ML] Initialize saved objects on trained model page load (#201426)\n\nFixes https://github.com/elastic/kibana/issues/201410\r\n\r\nOn page load, we now call the saved object initialization api which\r\ncreates any missing saved objects.","sha":"6a649b2e3c8a9a084a19b48f9f1e7de5ca3c4604","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd Party Models","backport:version","v8.18.0"],"title":"[ML] Initialize saved objects on trained model page load","number":201426,"url":"https://github.com/elastic/kibana/pull/201426","mergeCommit":{"message":"[ML] Initialize saved objects on trained model page load (#201426)\n\nFixes https://github.com/elastic/kibana/issues/201410\r\n\r\nOn page load, we now call the saved object initialization api which\r\ncreates any missing saved objects.","sha":"6a649b2e3c8a9a084a19b48f9f1e7de5ca3c4604"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201426","number":201426,"mergeCommit":{"message":"[ML] Initialize saved objects on trained model page load (#201426)\n\nFixes https://github.com/elastic/kibana/issues/201410\r\n\r\nOn page load, we now call the saved object initialization api which\r\ncreates any missing saved objects.","sha":"6a649b2e3c8a9a084a19b48f9f1e7de5ca3c4604"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201410
On page load, we now call the saved object initialization api which creates any missing saved objects.