Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163) #201404

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…efault Settings (elastic#201163)

## Summary

This PR solves the issues
elastic#195951 and
elastic#195942 getting the focus on the
first interactive element as suggested which is the _ingest pipelines_
external link after pressing enter using the keyboard navigation either
the _Reset_ or _Save_ buttons. With this the screen reader announces the
_ingest pipelines_ content after any of those previous events.

![CleanShot 2024-11-22 at 10 16
08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)

(cherry picked from commit 56ee089)
@kibanamachine kibanamachine merged commit a8bd887 into elastic:8.x Nov 22, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +135.0B

cc @JoseLuisGJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants