Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams] Adding the first integration test #201293

Merged
merged 6 commits into from
Nov 26, 2024
Merged

[Streams] Adding the first integration test #201293

merged 6 commits into from
Nov 26, 2024

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Nov 21, 2024 •
edited by kibanamachine
Loading

Summary

This PR introduces the first integration test for the Streams project. This test covers the following basic functionality:

  • Enable streams
  • Index a document to logs
  • Create a logs.nginx for that reroutes based on log.logger == 'nginx'
  • Index a document to logs.nginx
  • Create a logs.nginx.access that reroutes based on log.level == 'info'
  • Index a document to log.nginx.access

@simianhacker simianhacker marked this pull request as ready for review November 21, 2024 21:52
@simianhacker simianhacker requested review from a team as code owners November 21, 2024 21:52
@simianhacker simianhacker added v9.0.0 backport:skip This commit does not require backporting Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels Nov 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@simianhacker simianhacker added the release_note:skip Skip the PR/issue when compiling release notes label Nov 22, 2024
@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together! I can add a couple more for fields and processing

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #77 / Exception items APIs Authentication - Complete Tier @serverless @serverlessQA endpoint_operations_analyst exception items API behaviors read exception item should return 200 for endpoint_operations_analyst

Metrics [docs]

✅ unchanged

History

pheyos
pheyos approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just an observation: If you move your helpers to a service, they would be easier to reuse for future tests in other areas if needed and you wouldn't have to pass instances of supertest or esclient as they would be available to a service directly.

@flash1293 flash1293 merged commit aebd13e into elastic:main Nov 26, 2024
23 checks passed
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@simianhacker @kibanamachine
@elasticmachine @flash1293 @paulinashakirova
[Streams] Adding the first integration test (elastic#201293)
95d7152 
## Summary

This PR introduces the first integration test for the Streams project.
This test covers the following basic functionality:

- Enable streams
- Index a document to `logs`
- Create a `logs.nginx` for that reroutes based on `log.logger ==
'nginx'`
- Index a document to `logs.nginx`
- Create a `logs.nginx.access` that reroutes based on `log.level ==
'info'`
- Index a document to `log.nginx.access`

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
@flash1293 flash1293 added Feature:Streams This is the label for the Streams Project backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 and removed backport:skip This commit does not require backporting labels Dec 3, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12137605914

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12137605923

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2024
@simianhacker
[Streams] Adding the first integration test (elastic#201293)
0e9ffb0 
## Summary

This PR introduces the first integration test for the Streams project.
This test covers the following basic functionality:

- Enable streams
- Index a document to `logs`
- Create a `logs.nginx` for that reroutes based on `log.logger ==
'nginx'`
- Index a document to `logs.nginx`
- Create a `logs.nginx.access` that reroutes based on `log.level ==
'info'`
- Index a document to `log.nginx.access`

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
(cherry picked from commit aebd13e)
@kibanamachine kibanamachine mentioned this pull request Dec 3, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2024
@simianhacker
[Streams] Adding the first integration test (elastic#201293)
97a702a 
## Summary

This PR introduces the first integration test for the Streams project.
This test covers the following basic functionality:

- Enable streams
- Index a document to `logs`
- Create a `logs.nginx` for that reroutes based on `log.logger ==
'nginx'`
- Index a document to `logs.nginx`
- Create a `logs.nginx.access` that reroutes based on `log.level ==
'info'`
- Index a document to `log.nginx.access`

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
(cherry picked from commit aebd13e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 3, 2024
@kibanamachine @simianhacker
[8.x] [Streams] Adding the first integration test (#201293) (#202661)
cca3939 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Streams] Adding the first integration test
(#201293)](#201293)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Chris
Cowan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T09:43:25Z","message":"[Streams]
Adding the first integration test (#201293)\n\n## Summary\r\n\r\nThis PR
introduces the first integration test for the Streams project.\r\nThis
test covers the following basic functionality:\r\n\r\n- Enable
streams\r\n- Index a document to `logs`\r\n- Create a `logs.nginx` for
that reroutes based on `log.logger ==\r\n'nginx'`\r\n- Index a document
to `logs.nginx`\r\n- Create a `logs.nginx.access` that reroutes based on
`log.level ==\r\n'info'`\r\n- Index a document to
`log.nginx.access`\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"aebd13ec678d620c1822d313ea5c9bb6d219a149","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Observability","v9.0.0","backport:prev-minor","v8.18.0","Feature:Streams"],"title":"[Streams]
Adding the first integration
test","number":201293,"url":"https://github.com/elastic/kibana/pull/201293","mergeCommit":{"message":"[Streams]
Adding the first integration test (#201293)\n\n## Summary\r\n\r\nThis PR
introduces the first integration test for the Streams project.\r\nThis
test covers the following basic functionality:\r\n\r\n- Enable
streams\r\n- Index a document to `logs`\r\n- Create a `logs.nginx` for
that reroutes based on `log.logger ==\r\n'nginx'`\r\n- Index a document
to `logs.nginx`\r\n- Create a `logs.nginx.access` that reroutes based on
`log.level ==\r\n'info'`\r\n- Index a document to
`log.nginx.access`\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"aebd13ec678d620c1822d313ea5c9bb6d219a149"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201293","number":201293,"mergeCommit":{"message":"[Streams]
Adding the first integration test (#201293)\n\n## Summary\r\n\r\nThis PR
introduces the first integration test for the Streams project.\r\nThis
test covers the following basic functionality:\r\n\r\n- Enable
streams\r\n- Index a document to `logs`\r\n- Create a `logs.nginx` for
that reroutes based on `log.logger ==\r\n'nginx'`\r\n- Index a document
to `logs.nginx`\r\n- Create a `logs.nginx.access` that reroutes based on
`log.level ==\r\n'info'`\r\n- Index a document to
`log.nginx.access`\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"aebd13ec678d620c1822d313ea5c9bb6d219a149"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Chris Cowan <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@simianhacker @kibanamachine
@elasticmachine @flash1293 @CAWilson94
[Streams] Adding the first integration test (elastic#201293)
3d1d6de 
## Summary

This PR introduces the first integration test for the Streams project.
This test covers the following basic functionality:

- Enable streams
- Index a document to `logs`
- Create a `logs.nginx` for that reroutes based on `log.logger ==
'nginx'`
- Index a document to `logs.nginx`
- Create a `logs.nginx.access` that reroutes based on `log.level ==
'info'`
- Index a document to `log.nginx.access`

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@pheyos pheyos pheyos approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simianhacker @elasticmachine @kibanamachine @flash1293 @pheyos @Ikuni17