[deps] Replace faker with @faker-js #201105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
release_note:skip
mbondyra
approved these changes
Nov 21, 2024
markov00
force-pushed
the
2024_11_21-replace_faker_lib
branch
from
e986d83 to
5419268
Compare
patrykkopycinski
approved these changes
Dec 2, 2024
botelastic
bot
added
the
ci:project-deploy-observability
tonyghiani
approved these changes
Dec 2, 2024
dmlemeshko
added a commit
that referenced
this pull request
Dec 2, 2024
…02329) ## Summary @markov00 opened PR to [migrate](#201105) from `faker`, but it probably will take extra time and to keep track let's move its ownership to `team:kibana-visualizations` --------- Co-authored-by: Marco Vettorello <[email protected]>
1 task
PhilippeOberti
approved these changes
Dec 2, 2024
vitaliidm
reviewed
Dec 3, 2024
...ution_logic/indicator_match/trial_license_complete_tier/indicator_match_alert_suppression.ts
Show resolved
Hide resolved
vitaliidm
approved these changes
Dec 3, 2024
pgayvallet
approved these changes
Dec 3, 2024
mbondyra
approved these changes
Dec 3, 2024
neptunian
approved these changes
Dec 3, 2024
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12144804651 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task
markov00
added a commit
that referenced
this pull request
Dec 4, 2024
## Summary With the [replacement](#201105) of `faker` with `@faker-js` there is no more need of this renovate configuration.
markov00
added
backport:skip
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
## Summary The `faker` library is[ not maintained anymore](https://fakerjs.dev/about/announcements/2022-01-14.html#i-heard-something-happened-what-s-the-tldr) and is replaced by a community fork `@faker-js`. This PR migrates all the usages of faker to the new library, trying to use the same methods (even if they have slight differences in results like `faker.random.number()` has a max of 99999 where instead `faker.number.int()` have a MAX_SAFE_INTEGER as max).
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
## Summary With the [replacement](elastic#201105) of `faker` with `@faker-js` there is no more need of this renovate configuration.
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Summary With the [replacement](elastic#201105) of `faker` with `@faker-js` there is no more need of this renovate configuration.
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Summary With the [replacement](elastic#201105) of `faker` with `@faker-js` there is no more need of this renovate configuration.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…astic#202329) ## Summary @markov00 opened PR to [migrate](elastic#201105) from `faker`, but it probably will take extra time and to keep track let's move its ownership to `team:kibana-visualizations` --------- Co-authored-by: Marco Vettorello <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary The `faker` library is[ not maintained anymore](https://fakerjs.dev/about/announcements/2022-01-14.html#i-heard-something-happened-what-s-the-tldr) and is replaced by a community fork `@faker-js`. This PR migrates all the usages of faker to the new library, trying to use the same methods (even if they have slight differences in results like `faker.random.number()` has a max of 99999 where instead `faker.number.int()` have a MAX_SAFE_INTEGER as max).
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary With the [replacement](elastic#201105) of `faker` with `@faker-js` there is no more need of this renovate configuration.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…astic#202329) ## Summary @markov00 opened PR to [migrate](elastic#201105) from `faker`, but it probably will take extra time and to keep track let's move its ownership to `team:kibana-visualizations` --------- Co-authored-by: Marco Vettorello <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary The `faker` library is[ not maintained anymore](https://fakerjs.dev/about/announcements/2022-01-14.html#i-heard-something-happened-what-s-the-tldr) and is replaced by a community fork `@faker-js`. This PR migrates all the usages of faker to the new library, trying to use the same methods (even if they have slight differences in results like `faker.random.number()` has a max of 99999 where instead `faker.number.int()` have a MAX_SAFE_INTEGER as max).
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary With the [replacement](elastic#201105) of `faker` with `@faker-js` there is no more need of this renovate configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
fakerlibrary is not maintained anymore and is replaced by a community fork@faker-js.This PR migrates all the usages of faker to the new library, trying to use the same methods (even if they have slight differences in results like
faker.random.number()has a max of 99999 where insteadfaker.number.int()have a MAX_SAFE_INTEGER as max).