[Security Solution] Fix flaky test for multiline diff algorithm #201019
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
test
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
dplumlee
approved these changes
Nov 20, 2024
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11941814637 |
💚 Build Succeeded
Metrics [docs]
History
cc @banderror |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 20, 2024
…tic#201019) **Fixes: elastic#201014 **Related to:** elastic#199388 ## Summary This PR increases the threshold (time limit) value for the test by 2x from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness on CI. (cherry picked from commit c9e7820)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 20, 2024
…tic#201019) **Fixes: elastic#201014 **Related to:** elastic#199388 ## Summary This PR increases the threshold (time limit) value for the test by 2x from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness on CI. (cherry picked from commit c9e7820)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 20, 2024
…#201019) (#201044) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix flaky test for multiline diff algorithm (#201019)](#201019) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T21:12:02Z","message":"[Security Solution] Fix flaky test for multiline diff algorithm (#201019)\n\n**Fixes: https://github.com/elastic/kibana/issues/201014**\r\n**Related to:** https://github.com/elastic/kibana/pull/199388\r\n\r\n## Summary\r\n\r\nThis PR increases the threshold (time limit) value for the test by 2x\r\nfrom 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness\r\non CI.","sha":"c9e782030a768da471616d626096eb325e12c38c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.17.0","v8.16.1"],"title":"[Security Solution] Fix flaky test for multiline diff algorithm","number":201019,"url":"https://github.com/elastic/kibana/pull/201019","mergeCommit":{"message":"[Security Solution] Fix flaky test for multiline diff algorithm (#201019)\n\n**Fixes: https://github.com/elastic/kibana/issues/201014**\r\n**Related to:** https://github.com/elastic/kibana/pull/199388\r\n\r\n## Summary\r\n\r\nThis PR increases the threshold (time limit) value for the test by 2x\r\nfrom 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness\r\non CI.","sha":"c9e782030a768da471616d626096eb325e12c38c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201019","number":201019,"mergeCommit":{"message":"[Security Solution] Fix flaky test for multiline diff algorithm (#201019)\n\n**Fixes: https://github.com/elastic/kibana/issues/201014**\r\n**Related to:** https://github.com/elastic/kibana/pull/199388\r\n\r\n## Summary\r\n\r\nThis PR increases the threshold (time limit) value for the test by 2x\r\nfrom 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness\r\non CI.","sha":"c9e782030a768da471616d626096eb325e12c38c"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <[email protected]>
TattdCodeMonkey
pushed a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Nov 21, 2024
…tic#201019) **Fixes: elastic#201014 **Related to:** elastic#199388 ## Summary This PR increases the threshold (time limit) value for the test by 2x from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness on CI.
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
#201019) (#201043) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Fix flaky test for multiline diff algorithm (#201019)](#201019) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T21:12:02Z","message":"[Security Solution] Fix flaky test for multiline diff algorithm (#201019)\n\n**Fixes: https://github.com/elastic/kibana/issues/201014**\r\n**Related to:** https://github.com/elastic/kibana/pull/199388\r\n\r\n## Summary\r\n\r\nThis PR increases the threshold (time limit) value for the test by 2x\r\nfrom 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness\r\non CI.","sha":"c9e782030a768da471616d626096eb325e12c38c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.17.0","v8.16.1"],"title":"[Security Solution] Fix flaky test for multiline diff algorithm","number":201019,"url":"https://github.com/elastic/kibana/pull/201019","mergeCommit":{"message":"[Security Solution] Fix flaky test for multiline diff algorithm (#201019)\n\n**Fixes: https://github.com/elastic/kibana/issues/201014**\r\n**Related to:** https://github.com/elastic/kibana/pull/199388\r\n\r\n## Summary\r\n\r\nThis PR increases the threshold (time limit) value for the test by 2x\r\nfrom 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness\r\non CI.","sha":"c9e782030a768da471616d626096eb325e12c38c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201019","number":201019,"mergeCommit":{"message":"[Security Solution] Fix flaky test for multiline diff algorithm (#201019)\n\n**Fixes: https://github.com/elastic/kibana/issues/201014**\r\n**Related to:** https://github.com/elastic/kibana/pull/199388\r\n\r\n## Summary\r\n\r\nThis PR increases the threshold (time limit) value for the test by 2x\r\nfrom 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness\r\non CI.","sha":"c9e782030a768da471616d626096eb325e12c38c"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…tic#201019) **Fixes: elastic#201014 **Related to:** elastic#199388 ## Summary This PR increases the threshold (time limit) value for the test by 2x from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness on CI.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…tic#201019) **Fixes: elastic#201014 **Related to:** elastic#199388 ## Summary This PR increases the threshold (time limit) value for the test by 2x from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #201014
Related to: #199388
Summary
This PR increases the threshold (time limit) value for the test by 2x from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness on CI.