Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Borealis visualization palettes #201015

Merged
merged 54 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
b704815
borealis visualization palettes
nickofthyme Nov 20, 2024
47545cc
Merge branch 'main' into borealis-vis-palettes
stratoula Nov 21, 2024
6682ac9
chore: hardcode theme toggles [to be removed]
nickofthyme Nov 21, 2024
e28c667
chore: add chart background color override
nickofthyme Nov 21, 2024
fd1f32b
Merge branch 'main' into borealis-vis-palettes
nickofthyme Nov 21, 2024
adea40a
fix: color mappings, assign all button
nickofthyme Nov 22, 2024
a00e0fd
chore: add logic to use default eui base palette fn
nickofthyme Nov 22, 2024
9ce21f9
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Nov 23, 2024
81b5885
chore: update elastic palette with colors from eui
nickofthyme Nov 23, 2024
285588c
chore: fix type and jest errors
nickofthyme Nov 23, 2024
3eca8c4
chore: update page load limits
nickofthyme Nov 23, 2024
60d3ea9
chore: fix i18n errors
nickofthyme Nov 23, 2024
db7e5cf
Merge remote-tracking branch 'origin/borealis-vis-palettes' into bore…
nickofthyme Nov 23, 2024
0275557
fix: vis team name
nickofthyme Nov 23, 2024
bbe3409
fix: ts-config project references
nickofthyme Nov 23, 2024
c9944c0
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Nov 23, 2024
877b07a
Merge branch 'main' into borealis-vis-palettes
stratoula Nov 24, 2024
21e1b16
fix: get colors based on palette or color mapping
nickofthyme Nov 27, 2024
70688cc
chore: add observable palettes to Lens xy charts
nickofthyme Nov 27, 2024
fde389a
fix: ensure KibanaEuiProvider mounts with selected theme
mgadewoll Nov 27, 2024
890bcbf
Revert "chore: add observable palettes to Lens xy charts"
nickofthyme Dec 2, 2024
fd10121
chore: use eui color blind palette function
nickofthyme Dec 2, 2024
e1a22b5
chore: remove unused changes
nickofthyme Dec 2, 2024
4ef7bd8
fix: vega color palette assignment
nickofthyme Dec 2, 2024
a17c26c
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 2, 2024
75556ff
test: update jest tests
nickofthyme Dec 2, 2024
3dec075
fix: tagcloud RO loop
nickofthyme Dec 3, 2024
970df40
fix: color stops overrides for new theme
nickofthyme Dec 3, 2024
8ab25d0
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 3, 2024
4dfc1ab
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Dec 3, 2024
ed1291a
chore: fix linting and type errors
nickofthyme Dec 3, 2024
658a774
chore: apply sequential colors for partition charts
nickofthyme Dec 3, 2024
b82fe80
Merge remote-tracking branch 'origin/borealis-vis-palettes' into bore…
nickofthyme Dec 3, 2024
0b959a4
fix: test failures
nickofthyme Dec 3, 2024
62c3b1a
fix: vega page bundle size
nickofthyme Dec 4, 2024
d5f234a
chore: apply lightening for partition color logic
nickofthyme Dec 4, 2024
c060d3e
chore: remove hardcoded theming
nickofthyme Dec 5, 2024
dd54d94
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 5, 2024
8598e07
chore: hardcode theme toggles [to be removed]
nickofthyme Nov 21, 2024
8f01fae
Revert "chore: hardcode theme toggles [to be removed]"
nickofthyme Dec 5, 2024
149fdd5
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 5, 2024
7778db2
revert: bundle limit changes
nickofthyme Dec 5, 2024
dd190f1
test: fix jest async errors
nickofthyme Dec 5, 2024
bf2312d
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 5, 2024
b09aa09
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 9, 2024
6afbfe1
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 10, 2024
016f161
chore: address simple pr comments
nickofthyme Dec 10, 2024
a0532c9
fix: color method min color enforcement
nickofthyme Dec 11, 2024
978251d
fix: export static palettes
nickofthyme Dec 11, 2024
1dc23ab
chore: add description for `defaultNumberOfColors`
nickofthyme Dec 11, 2024
292f3de
test: fix duplicate render
nickofthyme Dec 11, 2024
4c7c09c
chore: add `fallbackColor` theme override
nickofthyme Dec 11, 2024
044124f
Merge branch 'main' into borealis-vis-palettes
nickofthyme Dec 11, 2024
600912f
chore: remove eslint override on tagcloud
nickofthyme Dec 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ packages/kbn-openapi-generator @elastic/security-detection-rule-management
packages/kbn-optimizer @elastic/kibana-operations
packages/kbn-optimizer-webpack-helpers @elastic/kibana-operations
packages/kbn-osquery-io-ts-types @elastic/security-asset-management
packages/kbn-palettes @elastic/kibana-visualizations
packages/kbn-panel-loader @elastic/kibana-presentation
packages/kbn-peggy @elastic/kibana-operations
packages/kbn-peggy-loader @elastic/kibana-operations
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,7 @@
"@kbn/osquery-plugin": "link:x-pack/plugins/osquery",
"@kbn/paertial-results-example-plugin": "link:examples/partial_results_example",
"@kbn/painless-lab-plugin": "link:x-pack/plugins/painless_lab",
"@kbn/palettes": "link:packages/kbn-palettes",
"@kbn/panel-loader": "link:packages/kbn-panel-loader",
"@kbn/plugin-check": "link:packages/kbn-plugin-check",
"@kbn/portable-dashboards-example": "link:examples/portable_dashboards_example",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export type ThemeTags = readonly ThemeTag[];
* An array of theme tags available in Kibana by default when not customized
* using KBN_OPTIMIZER_THEMES environment variable.
*/
export const DEFAULT_THEME_TAGS: ThemeTags = ThemeAmsterdamTags;
export const DEFAULT_THEME_TAGS: ThemeTags = SUPPORTED_THEME_TAGS; // TODO Nick put this back
// export const DEFAULT_THEME_TAGS: ThemeTags = ThemeAmsterdamTags;
nickofthyme marked this conversation as resolved.
Show resolved Hide resolved

export const FALLBACK_THEME_TAG: ThemeTag = 'v8light';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ export const getThemeSettings = (
}),
},
value: 'amsterdam',
readonly: Object.hasOwn(options, 'isThemeSwitcherEnabled')
? !options.isThemeSwitcherEnabled
: true,
// TODO Nick put this back
nickofthyme marked this conversation as resolved.
Show resolved Hide resolved
// readonly: Object.hasOwn(options, 'isThemeSwitcherEnabled')
// ? !options.isThemeSwitcherEnabled
// : true,
requiresPageReload: true,
schema: schema.oneOf([
schema.literal('amsterdam'),
Expand Down
2 changes: 2 additions & 0 deletions packages/kbn-coloring/src/palettes/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ export interface CustomPaletteParams {
progression?: 'fixed';
rangeMin?: number;
rangeMax?: number;
/** lower color stops */
stops?: ColorStop[];
/** upper color stops */
colorStops?: ColorStop[];
steps?: number;
maxSteps?: number | undefined;
Expand Down
Loading