-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ownership] Assign test files to mgmt team #200989
[Ownership] Assign test files to mgmt team #200989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this Tre! I had a look and most of these belong to other teams, only the UA one should be for us
.github/CODEOWNERS
Outdated
/x-pack/test/functional/fixtures/kbn_archiver/home @elastic/kibana-management | ||
/x-pack/test/functional/fixtures/kbn_archiver/rollup @elastic/kibana-management # Assigned per only uses are in management tests | ||
/test/functional/fixtures/kbn_archiver/management.json @elastic/kibana-management # Assigned per only uses are in management tests | ||
/test/functional/fixtures/es_archiver/makelogs @elastic/kibana-management # Assigned per only uses are in management tests | ||
/test/functional/fixtures/es_archiver/large_fields @elastic/kibana-management # Assigned per only use: https://github.com/elastic/kibana/blob/main/test/functional/apps/management/data_views/_test_huge_fields.ts#L25 | ||
/test/api_integration/fixtures/kbn_archiver/management @elastic/kibana-management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these tests even though are in the management folder belong to other teams, most of them are from the @elastic/kibana-data-discovery some others from other teams, only the upgrade_assistant es_archive
should be owned by our team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabarasaba Which tests are you referring to here?
I only see archives. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I meant all of these archives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/functional/apps/management/data_views/_test_huge_fields.ts
is the only use of test/functional/fixtures/es_archiver/large_fields
.
I think your team should own it bud. No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! But data_views
is owned by @elastic/kibana-data-discovery not by @elastic/kibana-management so I think it should go with them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-assigned 0b67745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest changes lgtm 🚀
So, the only use of
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
## Summary Assign test files to mgmt team Contributes to: elastic#192979
## Summary Assign test files to mgmt team Contributes to: elastic#192979
Summary
Assign test files to mgmt team
Contributes to: #192979