Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ownership] Assign test files to mgmt team #200989

Merged

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Nov 20, 2024

Summary

Assign test files to mgmt team

Contributes to: #192979

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 20, 2024
@wayneseymour wayneseymour requested a review from a team November 20, 2024 16:31
@wayneseymour wayneseymour self-assigned this Nov 20, 2024
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this Tre! I had a look and most of these belong to other teams, only the UA one should be for us

Comment on lines 1891 to 1896
/x-pack/test/functional/fixtures/kbn_archiver/home @elastic/kibana-management
/x-pack/test/functional/fixtures/kbn_archiver/rollup @elastic/kibana-management # Assigned per only uses are in management tests
/test/functional/fixtures/kbn_archiver/management.json @elastic/kibana-management # Assigned per only uses are in management tests
/test/functional/fixtures/es_archiver/makelogs @elastic/kibana-management # Assigned per only uses are in management tests
/test/functional/fixtures/es_archiver/large_fields @elastic/kibana-management # Assigned per only use: https://github.com/elastic/kibana/blob/main/test/functional/apps/management/data_views/_test_huge_fields.ts#L25
/test/api_integration/fixtures/kbn_archiver/management @elastic/kibana-management
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these tests even though are in the management folder belong to other teams, most of them are from the @elastic/kibana-data-discovery some others from other teams, only the upgrade_assistant es_archive should be owned by our team

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabarasaba Which tests are you referring to here?
I only see archives. 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I meant all of these archives

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/functional/apps/management/data_views/_test_huge_fields.ts is the only use of test/functional/fixtures/es_archiver/large_fields.
I think your team should own it bud. No?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-25 at 09 37 51

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! But data_views is owned by @elastic/kibana-data-discovery not by @elastic/kibana-management so I think it should go with them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-assigned 0b67745

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest changes lgtm 🚀

@wayneseymour wayneseymour enabled auto-merge (squash) November 25, 2024 09:56
@wayneseymour
Copy link
Member Author

So, the only use of x-pack/test/functional/fixtures/kbn_archiver/home/feature_controls/security/security.json is x-pack/test/functional/apps/home/feature_controls/home_security.ts
Owned by this team @sabarasaba

λ node scripts/get_owners_for_file.js --file x-pack/test/functional/apps/home/feature_controls/home_security.ts

succ elastic/kibana-management

@wayneseymour wayneseymour enabled auto-merge (squash) November 25, 2024 13:20
@wayneseymour wayneseymour merged commit d0f0809 into elastic:main Nov 25, 2024
23 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / useActionStatus should post cancel and invoke callback on cancel upgrade - plural
  • [job] [logs] Jest Tests #6 / useActionStatus should report error on cancel upgrade failure

Metrics [docs]

✅ unchanged

cc @wayneseymour

@wayneseymour wayneseymour deleted the assign-more-to-management-team branch November 25, 2024 15:29
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

Assign test files to mgmt team

Contributes to: elastic#192979
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Assign test files to mgmt team

Contributes to: elastic#192979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants