[ResponseOps][Cases] Removed custom render from flaky tests #200887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
technical debt
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
adcoelho
added
the
release_note:skip
cnasikas
approved these changes
Nov 20, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @adcoelho |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11953965483 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…200887) Closes elastic#189739 Closes elastic#188488 Closes elastic#193482 Closes elastic#192944 Closes elastic#195672 ## Summary Same solution for all of them, I removed `createAppMockRenderer`. In some cases, I also added missing occurrences of `screen` and updated `getBy`s to `await screen.findBy*`s. (cherry picked from commit d3b9a9a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…00887) (#201186) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Removed custom render from flaky tests (#200887)](#200887) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T13:13:28Z","message":"[ResponseOps][Cases] Removed custom render from flaky tests (#200887)\n\nCloses #189739\r\nCloses #188488\r\nCloses #193482\r\nCloses #192944\r\nCloses #195672\r\n\r\n## Summary\r\n\r\nSame solution for all of them, I removed `createAppMockRenderer`. In\r\nsome cases, I also added missing occurrences of `screen` and updated\r\n`getBy`s to `await screen.findBy*`s.","sha":"d3b9a9a050f1c7b2d77710bda55b2e59ec6b668a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["technical debt","release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor"],"title":"[ResponseOps][Cases] Removed custom render from flaky tests","number":200887,"url":"https://github.com/elastic/kibana/pull/200887","mergeCommit":{"message":"[ResponseOps][Cases] Removed custom render from flaky tests (#200887)\n\nCloses #189739\r\nCloses #188488\r\nCloses #193482\r\nCloses #192944\r\nCloses #195672\r\n\r\n## Summary\r\n\r\nSame solution for all of them, I removed `createAppMockRenderer`. In\r\nsome cases, I also added missing occurrences of `screen` and updated\r\n`getBy`s to `await screen.findBy*`s.","sha":"d3b9a9a050f1c7b2d77710bda55b2e59ec6b668a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200887","number":200887,"mergeCommit":{"message":"[ResponseOps][Cases] Removed custom render from flaky tests (#200887)\n\nCloses #189739\r\nCloses #188488\r\nCloses #193482\r\nCloses #192944\r\nCloses #195672\r\n\r\n## Summary\r\n\r\nSame solution for all of them, I removed `createAppMockRenderer`. In\r\nsome cases, I also added missing occurrences of `screen` and updated\r\n`getBy`s to `await screen.findBy*`s.","sha":"d3b9a9a050f1c7b2d77710bda55b2e59ec6b668a"}}]}] BACKPORT--> Co-authored-by: Antonio <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…200887) Closes elastic#189739 Closes elastic#188488 Closes elastic#193482 Closes elastic#192944 Closes elastic#195672 ## Summary Same solution for all of them, I removed `createAppMockRenderer`. In some cases, I also added missing occurrences of `screen` and updated `getBy`s to `await screen.findBy*`s.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…200887) Closes elastic#189739 Closes elastic#188488 Closes elastic#193482 Closes elastic#192944 Closes elastic#195672 ## Summary Same solution for all of them, I removed `createAppMockRenderer`. In some cases, I also added missing occurrences of `screen` and updated `getBy`s to `await screen.findBy*`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189739
Closes #188488
Closes #193482
Closes #192944
Closes #195672
Summary
Same solution for all of them, I removed
createAppMockRenderer. In some cases, I also added missing occurrences ofscreenand updatedgetBys toawait screen.findBy*s.