[ResponseOps][Cases] Fix SyncAlertsToggle flaky test
#200870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
technical debt
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
💚 Build Succeeded
Metrics [docs]
cc @adcoelho |
cnasikas
approved these changes
Nov 20, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11950305955 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
Fixes elastic#190270 ## Summary We already wrap `SyncAlertsToggle` in `<FormTestComponent>` so I removed `createAppMockRenderer` which wasn't necessary. (cherry picked from commit d91d82c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
#200870) (#201093) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Fix `SyncAlertsToggle` flaky test (#200870)](#200870) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T09:26:10Z","message":"[ResponseOps][Cases] Fix `SyncAlertsToggle` flaky test (#200870)\n\nFixes #190270\r\n\r\n## Summary\r\n\r\nWe already wrap `SyncAlertsToggle` in `<FormTestComponent>` so I removed\r\n`createAppMockRenderer` which wasn't necessary.","sha":"d91d82c2b9581821cf5ee30e8987a13f2d33b907","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["technical debt","release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor"],"title":"[ResponseOps][Cases] Fix `SyncAlertsToggle` flaky test","number":200870,"url":"https://github.com/elastic/kibana/pull/200870","mergeCommit":{"message":"[ResponseOps][Cases] Fix `SyncAlertsToggle` flaky test (#200870)\n\nFixes #190270\r\n\r\n## Summary\r\n\r\nWe already wrap `SyncAlertsToggle` in `<FormTestComponent>` so I removed\r\n`createAppMockRenderer` which wasn't necessary.","sha":"d91d82c2b9581821cf5ee30e8987a13f2d33b907"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200870","number":200870,"mergeCommit":{"message":"[ResponseOps][Cases] Fix `SyncAlertsToggle` flaky test (#200870)\n\nFixes #190270\r\n\r\n## Summary\r\n\r\nWe already wrap `SyncAlertsToggle` in `<FormTestComponent>` so I removed\r\n`createAppMockRenderer` which wasn't necessary.","sha":"d91d82c2b9581821cf5ee30e8987a13f2d33b907"}}]}] BACKPORT--> Co-authored-by: Antonio <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
Fixes elastic#190270 ## Summary We already wrap `SyncAlertsToggle` in `<FormTestComponent>` so I removed `createAppMockRenderer` which wasn't necessary.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Fixes elastic#190270 ## Summary We already wrap `SyncAlertsToggle` in `<FormTestComponent>` so I removed `createAppMockRenderer` which wasn't necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190270
Summary
We already wrap
SyncAlertsTogglein<FormTestComponent>so I removedcreateAppMockRendererwhich wasn't necessary.