-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16] [OAS] Publish OAS bundles to bump.sh (#197482) #200136
Conversation
## Summary Publish OAS docs to bump.sh on merge to `main` or `8.x` ## To reviewers * For now actual publication requires a manual step on bump.sh (so things aren't going live immediately) * Will get to serverless OAS docs next! ## Blockers * Address vulnerable deps before merging: bump-sh/cli#583 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 8278b06) # Conflicts: # oas_docs/makefile # oas_docs/output/kibana.serverless.yaml # oas_docs/output/kibana.yaml
@elasticmachine merge upstream |
exit 0; | ||
fi | ||
|
||
if [[ "$BUILDKITE_BRANCH" == "8.x" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [[ "$BUILDKITE_BRANCH" == "8.x" ]]; then
I presume in this branch we'll need to add another clause like this, but for the 8.16 branch and targeting the "v8" branch in Bump.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a good point... this step won't do anything on this branch.
One alternative for back port branches: we could "set and forget" to e.g. 8.16. But I guess that would mean a lot more branches on bump. Perhaps worth leaving out this back port for now. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it looks like we have at least one more 8.16 release before 8.17 takes over, I'm leaning toward having the clause in here to publish to the v8 branch. The docs team just needs to remember to comment it out when it comes time to switch to 8.17.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an 8.16 section in d90c609
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ that sounds good, we'll have to change the check to 8.17
on that branch
💚 Build Succeeded
Metrics [docs]
History
|
Backport
This will backport the following commits from
main
to8.16
:Questions ?
Please refer to the Backport tool documentation