[Papercut] Fix KQL parsing error text styling #199985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalczyk-krzysztof
added
bug
kibanamachine
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
kowalczyk-krzysztof
added
impact:low
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
approved these changes
Nov 13, 2024
nreese
reviewed
Nov 13, 2024
| @@ -16,13 +17,19 @@ interface Props { | |||
| } | |||
|
|
|||
| export function LegendDetails({ inspectorAdapters, layer }: Props) { | |||
| const { euiTheme } = useEuiTheme(); | |||
There was a problem hiding this comment.
How about moving errorTextStyle into a hook in packages/kbn-react-hooks so that it can be defined in a single location?
So define
export function useErrorTextStyle() {
const { euiTheme } = useEuiTheme();
return css`
font-family: ${euiTheme.font.familyCode};
white-space: break-spaces;
`;
}
There was a problem hiding this comment.
Thanks for the suggestion. Implemented.
kowalczyk-krzysztof
force-pushed
the
fix/kql-error-parsing-style
branch
from
737c046 to
043d333
Compare
awahab07
reviewed
Nov 14, 2024
packages/kbn-react-hooks/README.md
Outdated
| ``` | ||
|
|
||
| ### [useErrorTextStyle](./src/useErrorTextStyle) |
There was a problem hiding this comment.
I believe this will create a broken link in README. I guess the existing link for useBoolean is also broken.
There was a problem hiding this comment.
Thanks for noticing this @awahab07
Fixed both links.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11891635339 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR fixes styling for `KQL parsing error` text on various elements on `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on new line. Closes: elastic#49377     --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a8fc787)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Papercut] Fix KQL parsing error text styling (#199985)](#199985) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T11:37:49Z","message":"[Papercut] Fix KQL parsing error text styling (#199985)\n\n## Summary\r\n\r\nThis PR fixes styling for `KQL parsing error` text on various elements\r\non `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on\r\nnew line.\r\n\r\nCloses: #49377\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a8fc787cdbda54cd54e58a37e3c1163af62864dd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Dashboard","Team:Presentation","loe:small","Team:Visualizations","release_note:skip","impact:low","v9.0.0","backport:prev-minor","Feature:Maps"],"title":"[Papercut] Fix KQL parsing error text styling","number":199985,"url":"https://github.com/elastic/kibana/pull/199985","mergeCommit":{"message":"[Papercut] Fix KQL parsing error text styling (#199985)\n\n## Summary\r\n\r\nThis PR fixes styling for `KQL parsing error` text on various elements\r\non `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on\r\nnew line.\r\n\r\nCloses: #49377\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a8fc787cdbda54cd54e58a37e3c1163af62864dd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199985","number":199985,"mergeCommit":{"message":"[Papercut] Fix KQL parsing error text styling (#199985)\n\n## Summary\r\n\r\nThis PR fixes styling for `KQL parsing error` text on various elements\r\non `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on\r\nnew line.\r\n\r\nCloses: #49377\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a8fc787cdbda54cd54e58a37e3c1163af62864dd"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR fixes styling for `KQL parsing error` text on various elements on `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on new line. Closes: elastic#49377     --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary This PR fixes styling for `KQL parsing error` text on various elements on `Maps` and `Dashboard` to have the invalid syntax and ASCII arrow on new line. Closes: elastic#49377     --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes styling for
KQL parsing errortext on various elements onMapsandDashboardto have the invalid syntax and ASCII arrow on new line.Closes: #49377