[kbn/flot-charts] Use jQuery methods to build legends #199871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpeihl
added
Team:Monitoring
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]Async chunks
|
nreese
approved these changes
Nov 13, 2024
|
Starting backport for target branches: 7.17, 8.15, 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11824223106 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
## Summary Updates the kbn/flot-charts package to use jQuery methods for legend construction. (cherry picked from commit 1f5fe1d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
## Summary Updates the kbn/flot-charts package to use jQuery methods for legend construction. (cherry picked from commit 1f5fe1d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
## Summary Updates the kbn/flot-charts package to use jQuery methods for legend construction. (cherry picked from commit 1f5fe1d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
## Summary Updates the kbn/flot-charts package to use jQuery methods for legend construction. (cherry picked from commit 1f5fe1d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
#200076) # Backport This will backport the following commits from `main` to `8.15`: - [[kbn/flot-charts] Use jQuery methods to build legends (#199871)](#199871) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T19:15:18Z","message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Monitoring","Team:Presentation","release_note:skip","v9.0.0","backport:all-open"],"title":"[kbn/flot-charts] Use jQuery methods to build legends","number":199871,"url":"https://github.com/elastic/kibana/pull/199871","mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199871","number":199871,"mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
#200077) # Backport This will backport the following commits from `main` to `8.16`: - [[kbn/flot-charts] Use jQuery methods to build legends (#199871)](#199871) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T19:15:18Z","message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Monitoring","Team:Presentation","release_note:skip","v9.0.0","backport:all-open"],"title":"[kbn/flot-charts] Use jQuery methods to build legends","number":199871,"url":"https://github.com/elastic/kibana/pull/199871","mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199871","number":199871,"mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
…#200078) # Backport This will backport the following commits from `main` to `8.x`: - [[kbn/flot-charts] Use jQuery methods to build legends (#199871)](#199871) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T19:15:18Z","message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Monitoring","Team:Presentation","release_note:skip","v9.0.0","backport:all-open"],"title":"[kbn/flot-charts] Use jQuery methods to build legends","number":199871,"url":"https://github.com/elastic/kibana/pull/199871","mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199871","number":199871,"mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
#200075) # Backport This will backport the following commits from `main` to `7.17`: - [[kbn/flot-charts] Use jQuery methods to build legends (#199871)](#199871) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T19:15:18Z","message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Monitoring","Team:Presentation","release_note:skip","v9.0.0","backport:all-open"],"title":"[kbn/flot-charts] Use jQuery methods to build legends","number":199871,"url":"https://github.com/elastic/kibana/pull/199871","mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199871","number":199871,"mergeCommit":{"message":"[kbn/flot-charts] Use jQuery methods to build legends (#199871)\n\n## Summary\r\n\r\nUpdates the kbn/flot-charts package to use jQuery methods for legend\r\nconstruction.","sha":"1f5fe1d7ceee071dcfc361534d068cdaecb5b098"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Updates the kbn/flot-charts package to use jQuery methods for legend construction.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Updates the kbn/flot-charts package to use jQuery methods for legend construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the kbn/flot-charts package to use jQuery methods for legend construction.
Background:
In #195643 we attempted to replace our copy of the flot library with the changes in flot/flot#1184 which removes unsafe inline style templating among other updates. Even though Canvas charts continued to render, some stack monitoring charts failed. We reverted the PR in #198067 in favor of a more targeted approach.
The unsafe inline style templates (example) only exist in the
insertLegendfunction of flot. These templates were fixed in the 0.9.0 version by using native jQuery methods to construct elements. So rather than updating the entire library, this PR only updates theinsertLegendfunction from the https://github.com/flot/flot/tree/0.9-work branch.The version of flot we use is 0.8.3 and the latest version of flot is 4.x. I don’t think it makes sense to try and jump four major versions just to maintain compatibility with legacy Canvas charts and stack monitoring charts. That is why we opted to use the latest 0.9 version of flot for this PR.